Skip to content

Commit 5bc5e13

Browse files
knopers8knopers8
committed
copyrights and header inclusion cleanups
1 parent 0e35973 commit 5bc5e13

15 files changed

Lines changed: 133 additions & 57 deletions

‎Framework/include/QualityControl/Actor.h‎

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,18 @@
1+
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.
2+
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
3+
// All rights not expressly granted are reserved.
14
//
2-
// Created by pkonopka on 23/06/25.
5+
// This software is distributed under the terms of the GNU General Public
6+
// License v3 (GPL Version 3), copied verbatim in the file "COPYING".
37
//
8+
// In applying this license CERN does not waive the privileges and immunities
9+
// granted to it by virtue of its status as an Intergovernmental Organization
10+
// or submit itself to any jurisdiction.
11+
12+
///
13+
/// \file Actor.h
14+
/// \author Piotr Konopka
15+
///
416

517
#ifndef ACTOR_H
618
#define ACTOR_H
@@ -12,16 +24,15 @@
1224
#include <format>
1325
#include <functional>
1426

15-
#include "QualityControl/ActorTraits.h"
16-
#include "QualityControl/runnerUtils.h"
17-
#include "QualityControl/ServicesConfig.h"
18-
1927
#include <Framework/CallbackService.h>
2028
#include <Framework/InitContext.h>
2129
#include <Framework/ProcessingContext.h>
2230
#include <Framework/EndOfStreamContext.h>
2331
#include <Framework/ConcreteDataMatcher.h>
2432

33+
#include "QualityControl/ActorTraits.h"
34+
#include "QualityControl/runnerUtils.h"
35+
#include "QualityControl/ServicesConfig.h"
2536

2637
namespace o2::monitoring {
2738
class Monitoring;

‎Framework/include/QualityControl/ActorHelpers.h‎

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,32 @@
1+
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.
2+
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
3+
// All rights not expressly granted are reserved.
14
//
2-
// Created by pkonopka on 07/11/25.
5+
// This software is distributed under the terms of the GNU General Public
6+
// License v3 (GPL Version 3), copied verbatim in the file "COPYING".
37
//
8+
// In applying this license CERN does not waive the privileges and immunities
9+
// granted to it by virtue of its status as an Intergovernmental Organization
10+
// or submit itself to any jurisdiction.
11+
12+
///
13+
/// \file ActorHelpers.h
14+
/// \author Piotr Konopka
15+
///
416

517
#ifndef ACTORFACTORY_H
618
#define ACTORFACTORY_H
719

20+
#include <format>
21+
#include <ranges>
22+
23+
#include <Framework/DataProcessorSpec.h>
24+
825
#include "QualityControl/InfrastructureSpecReader.h"
926
#include "QualityControl/ActorTraits.h"
1027
#include "QualityControl/InputUtils.h"
1128
#include "QualityControl/ServicesConfig.h"
1229
#include "QualityControl/UserCodeConfig.h"
13-
#include <format>
14-
#include <ranges>
15-
#include <Framework/DataProcessorSpec.h>
1630

1731
namespace o2::quality_control::core {
1832

‎Framework/include/QualityControl/ActorTraits.h‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,17 +17,14 @@
1717
#ifndef ACTORTRAITS_H
1818
#define ACTORTRAITS_H
1919

20-
#include "QualityControl/DataSourceSpec.h"
21-
#include "QualityControl/stringUtils.h"
22-
2320
#include <string_view>
24-
// #include <vector>
2521
#include <ranges>
22+
2623
#include <Headers/DataHeader.h>
2724
#include <BookkeepingApi/DplProcessType.h>
2825

29-
// #include "QcInfoLogger.h"
30-
26+
#include "QualityControl/DataSourceSpec.h"
27+
#include "QualityControl/stringUtils.h"
3128

3229
// ActorTraits and specializations should not bring a lot of dependencies.
3330
// They should define the expected traits for each QC Actor and basic behaviours.
@@ -104,7 +101,8 @@ concept ValidActorTraits = requires
104101
true);
105102

106103

107-
// we want to know if this Actor runs user code. fixme: could be simplified to a bool
104+
// we want to know if this Actor runs user code.
105+
// fixme: now could be simplified to a bool, but maybe some future usage will need One/Many distinction
108106
{ ActorTraitsT::sUserCodeInstanceCardinality } -> std::convertible_to<UserCodeInstanceCardinality>;
109107

110108
// do we normally associate this Actor with a specific detector (in the worst case, with "MANY" or "MISC")

‎Framework/include/QualityControl/DataProcessorAdapter.h‎

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,28 @@
1+
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.
2+
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
3+
// All rights not expressly granted are reserved.
14
//
2-
// Created by pkonopka on 02/12/2025.
5+
// This software is distributed under the terms of the GNU General Public
6+
// License v3 (GPL Version 3), copied verbatim in the file "COPYING".
37
//
8+
// In applying this license CERN does not waive the privileges and immunities
9+
// granted to it by virtue of its status as an Intergovernmental Organization
10+
// or submit itself to any jurisdiction.
411

512
#ifndef QUALITYCONTROL_DATAPROCESSORADAPTER_H
613
#define QUALITYCONTROL_DATAPROCESSORADAPTER_H
714

15+
///
16+
/// \file DataProcessorAdapter.h
17+
/// \author Piotr Konopka
18+
///
19+
20+
#include <Framework/DataProcessorSpec.h>
21+
822
#include "QualityControl/Actor.h"
923
#include "QualityControl/ActorTraits.h"
1024
#include "QualityControl/ActorHelpers.h"
1125

12-
#include <Framework/DataProcessorSpec.h>
13-
1426
namespace o2::quality_control::core {
1527

1628
struct DataProcessorAdapter

‎Framework/include/QualityControl/LateTaskConfig.h‎

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,15 @@
1212
#ifndef QC_CORE_LATETASKRUNNERCONFIG_H
1313
#define QC_CORE_LATETASKRUNNERCONFIG_H
1414

15-
#include "QualityControl/UserCodeConfig.h"
16-
#include "QualityControl/DataSourceSpec.h"
15+
///
16+
/// \file LateTaskRunnerConfig.h
17+
/// \author Piotr Konopka
18+
///
1719

1820
#include <Framework/DataProcessorSpec.h>
1921

22+
#include "QualityControl/UserCodeConfig.h"
23+
#include "QualityControl/DataSourceSpec.h"
2024

2125
namespace o2::quality_control::core {
2226

‎Framework/include/QualityControl/LateTaskFactory.h‎

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,24 @@
1+
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.
2+
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
3+
// All rights not expressly granted are reserved.
14
//
2-
// Created by pkonopka on 23/06/25.
5+
// This software is distributed under the terms of the GNU General Public
6+
// License v3 (GPL Version 3), copied verbatim in the file "COPYING".
37
//
8+
// In applying this license CERN does not waive the privileges and immunities
9+
// granted to it by virtue of its status as an Intergovernmental Organization
10+
// or submit itself to any jurisdiction.
411

512
#ifndef LATETASKFACTORY_H
613
#define LATETASKFACTORY_H
714

8-
// STL
15+
///
16+
/// \file LateTaskFactory.h
17+
/// \author Piotr Konopka
18+
///
19+
920
#include <memory>
10-
// QC
21+
1122
#include "QualityControl/LateTaskConfig.h"
1223
#include "QualityControl/LateTaskInterface.h"
1324
#include "QualityControl/RootClassFactory.h"

‎Framework/include/QualityControl/LateTaskInterface.h‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,19 +9,19 @@
99
// granted to it by virtue of its status as an Intergovernmental Organization
1010
// or submit itself to any jurisdiction.
1111

12+
#ifndef QC_CORE_LATETASKINTERFACE_H
13+
#define QC_CORE_LATETASKINTERFACE_H
14+
1215
///
1316
/// \file LateTaskInterface.h
1417
/// \author Piotr Konopka
1518
///
1619

17-
#ifndef QC_CORE_LATETASKINTERFACE_H
18-
#define QC_CORE_LATETASKINTERFACE_H
19-
2020
#include <memory>
21-
// O2
21+
2222
#include <Framework/InitContext.h>
2323
#include <Framework/ProcessingContext.h>
24-
// QC
24+
2525
#include "QualityControl/Activity.h"
2626
#include "QualityControl/ObjectsManager.h"
2727
#include "QualityControl/UserCodeInterface.h"

‎Framework/include/QualityControl/LateTaskRunner.h‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,14 @@
1717
/// \author Piotr Konopka
1818
///
1919

20+
#include <string_view>
21+
#include <memory>
22+
2023
#include "QualityControl/LateTaskConfig.h"
2124
#include "QualityControl/LateTaskRunnerTraits.h"
22-
2325
#include "QualityControl/ActorTraits.h"
2426
#include "QualityControl/Actor.h"
25-
#include <string_view>
26-
#include <memory>
27+
2728

2829
namespace o2::quality_control::core {
2930

‎Framework/include/QualityControl/LateTaskRunnerFactory.h‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,21 @@
99
// granted to it by virtue of its status as an Intergovernmental Organization
1010
// or submit itself to any jurisdiction.
1111

12+
#ifndef QC_CORE_LATETASKRUNNERFACTORY_H
13+
#define QC_CORE_LATETASKRUNNERFACTORY_H
14+
1215
///
1316
/// \file LateTaskRunnerFactory.h
1417
/// \author Piotr Konopka
1518
///
1619

17-
#ifndef QC_CORE_LATETASKRUNNERFACTORY_H
18-
#define QC_CORE_LATETASKRUNNERFACTORY_H
19-
2020
#include <vector>
2121
#include <optional>
2222

23-
#include "QualityControl/LateTaskConfig.h"
2423
#include <Framework/DataProcessorSpec.h>
2524

25+
#include "QualityControl/LateTaskConfig.h"
26+
2627
namespace o2::framework
2728
{
2829
class CompletionPolicy;

‎Framework/include/QualityControl/LateTaskRunnerTraits.h‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,15 @@
1212
#ifndef QUALITYCONTROL_LATETASKRUNNERTRAITS_H
1313
#define QUALITYCONTROL_LATETASKRUNNERTRAITS_H
1414

15-
#include "QualityControl/ActorTraits.h"
15+
///
16+
/// \file LateTaskRunnerTraits.h
17+
/// \author Piotr Konopka
18+
///
1619

1720
#include <string_view>
1821
#include <array>
22+
23+
#include "QualityControl/ActorTraits.h"
1924
#include "QualityControl/DataSourceSpec.h"
2025

2126
namespace o2::quality_control::core {

0 commit comments

Comments
 (0)