Possibility to connect QC to readout without DS (QC-140) (#133)

Author: Barthelemy

Framework/CMakeLists.txt

@@ -287,6 +287,7 @@ install(
     basic-no-sampling.json
     advanced.json
     readout.json
+    readout-no-sampling.json
     readoutForDataDump.json
   DESTINATION etc
 )

Framework/readout-no-sampling.json

@@ -0,0 +1,36 @@
+{
+  "qc": {
+    "config": {
+      "database": {
+        "implementation": "CCDB",
+        "host": "ccdb-test.cern.ch:8080",
+        "username": "not_applicable",
+        "password": "not_applicable",
+        "name": "not_applicable"
+      },
+      "Activity": {
+        "number": "42",
+        "type": "2"
+      }
+    },
+    "tasks": {
+      "daqTask": {
+        "active": "true",
+        "className": "o2::quality_control_modules::daq::DaqTask",
+        "moduleName": "QcDaq",
+        "cycleDurationSeconds": "10",
+        "maxNumberCycles": "-1",
+        "dataSource": {
+          "type": "direct",
+          "binding": "readout",
+          "dataOrigin": "ITS",
+          "dataDescription": "RAWDATA",
+          "subSpec": "0"
+        },
+        "location": "remote"
+      }
+    }
+  },
+  "dataSamplingPolicies": [
+  ]
+}

Framework/readout.json

@@ -16,8 +16,8 @@
     "tasks": {
       "daqTask": {
         "active": "true",
-        "className": "o2::quality_control_modules::skeleton::SkeletonTask",
-        "moduleName": "QcSkeleton",
+        "className": "o2::quality_control_modules::daq::DaqTask",
+        "moduleName": "QcDaq",
         "cycleDurationSeconds": "10",
         "maxNumberCycles": "-1",
         "dataSource": {

Framework/src/runReadout.cxx

@@ -47,7 +47,9 @@ void customize(std::vector<ChannelConfigurationPolicy>& policies)
 void customize(std::vector<ConfigParamSpec>& workflowOptions)
 {
   workflowOptions.push_back(
-    ConfigParamSpec{"config-path", VariantType::String, "", {"Path to the config file."}});
+    ConfigParamSpec{ "config-path", VariantType::String, "", { "Path to the config file. Overwrite the default paths. Do not use with no-data-sampling." } });
+  workflowOptions.push_back(
+    ConfigParamSpec{ "no-data-sampling", VariantType::Bool, false, { "Skips data sampling, connects directly the task to the producer." } });
 }
 
 #include <TH1F.h>
@@ -125,10 +127,11 @@ WorkflowSpec defineDataProcessing(ConfigContext const& config)
 
 std::string getConfigPath(const ConfigContext& config)
 {
-  std::string userConfigPath = config.options().get<std::string>("config-path");
-  std::string defaultConfigPath = getenv("QUALITYCONTROL_ROOT") != nullptr ?
-                                           std::string(getenv("QUALITYCONTROL_ROOT")) + "/etc/readout.json" : "$QUALITYCONTROL_ROOT undefined";
-  std::string path = userConfigPath == "" ? defaultConfigPath : userConfigPath;
+  bool noDS = config.options().get<bool>("no-data-sampling");
+  std::string filename = !noDS ? "readout.json" : "readout-no-sampling.json";
+  auto userConfigPath = config.options().get<std::string>("config-path");
+  std::string defaultConfigPath = getenv("QUALITYCONTROL_ROOT") != nullptr ? std::string(getenv("QUALITYCONTROL_ROOT")) + "/etc/" + filename : "$QUALITYCONTROL_ROOT undefined";
+  std::string path = userConfigPath.empty() ? defaultConfigPath : userConfigPath;
   const std::string qcConfigurationSource = std::string("json:/") + path;
   return qcConfigurationSource;
 }