A refactoring went wrong and some method are not called correclty (#743)

Author: Barthelemy

Framework/CMakeLists.txt

@@ -400,6 +400,7 @@ install(FILES script/RepoCleaner/rules/1_per_hour.py
               script/RepoCleaner/rules/skip.py
               script/RepoCleaner/rules/1_per_run.py
               script/RepoCleaner/rules/none_kept.py
+              script/RepoCleaner/rules/last_only.py
         DESTINATION lib)
 
 # ---- Copy test files ----

Framework/script/RepoCleaner/rules/1_per_hour.py

@@ -32,7 +32,7 @@ def process(ccdb: Ccdb, object_path: str, delay: int, #migration: bool,
     deletion_list: List[ObjectVersion] = []
     update_list: List[ObjectVersion] = []
     for v in versions:
-        if last_preserved == None or last_preserved.validFromAsDatetime < v.validFromAsDt - timedelta(hours=1):
+        if last_preserved == None or last_preserved.validFromAsDt < v.validFromAsDt - timedelta(hours=1):
             # first extend validity of the previous preserved (should we take into account the run ?)
             if last_preserved != None:
                 ccdb.updateValidity(last_preserved, last_preserved.validFrom, str(int(v.validFrom) - 1))

Framework/script/RepoCleaner/rules/1_per_run.py

@@ -62,7 +62,7 @@ def process(ccdb: Ccdb, object_path: str, delay: int, extra_params: Dict[str, st
         freshest: ObjectVersion = None
         for v in run_versions:
             # logging.debug(f"  - version {v}")
-            if freshest is None or freshest.validFromAsDatetime < v.validFromAsDt:
+            if freshest is None or freshest.validFromAsDt < v.validFromAsDt:
                 if freshest is not None:
                     if in_grace_period(freshest, delay):
                         preservation_list.append(freshest)

Framework/script/RepoCleaner/rules/last_only.py

@@ -28,7 +28,7 @@ def process(ccdb: Ccdb, object_path: str, delay: int, extra_params: Dict[str, st
     deletion_list: List[ObjectVersion] = []
     # find the earliest
     for v in versions:
-        if earliest == None or v.validFromAsDt > earliest.validFromAsDatetime:
+        if earliest == None or v.validFromAsDt > earliest.validFromAsDt:
             earliest = v
     logging.debug(f"earliest : {earliest}")