CTP: new check and trending histograms (#2204)

* add trending and check for input and class ratios + configurable parameters for check

* implementation of the requested changes

* code simplification for the input and class rate check

* add check in order not to divide by 0

* implementation of the requested changes

---------

Co-authored-by: Lucia Anna Tarasovicova <lucia.anna.husova@cern.ch>

Author: lhusova

Modules/CTP/include/CTP/RawDataQcTask.h

@@ -50,6 +50,8 @@ class CTPRawDataReaderTask final : public TaskInterface
   o2::ctp::RawDataDecoder mDecoder;
   TH1F* mHistoInputs = nullptr;
   TH1F* mHistoClasses = nullptr;
+  TH1F* mHistoInputRatios = nullptr;
+  TH1F* mHistoClassRatios = nullptr;
   TH1F* mHistoMTVXBC = nullptr;
 };
 

Modules/CTP/include/CTP/RawDataReaderCheck.h

@@ -40,7 +40,7 @@ class RawDataReaderCheck : public o2::quality_control::checker::CheckInterface
   std::string getAcceptedType() override;
   void startOfActivity(const Activity& activity) override;
 
-  ClassDefOverride(RawDataReaderCheck, 4);
+  ClassDefOverride(RawDataReaderCheck, 5);
 
  private:
   int getRunNumberFromMO(std::shared_ptr<MonitorObject> mo);
@@ -49,10 +49,20 @@ class RawDataReaderCheck : public o2::quality_control::checker::CheckInterface
   int mRunNumber;
   long int mTimestamp;
   float mThreshold;
-  int inputCycleCounter;
-  int classCycleCounter;
+  float mThresholdRateBad;
+  float mThresholdRateMedium;
+  float mThresholdRateRatioBad;
+  float mThresholdRateRatioMedium;
+  int cycleCounter;
+  int mIndexMBclass = -1;
+  float mFraction;
+  int mCycleDuration;
+  bool relativeRates = false;
+  bool inputRates = false;
   TH1F* fHistInputPrevious;
   TH1F* fHistClassesPrevious;
+  TH1F* fHistInputRatioPrevious;
+  TH1F* fHistClassRatioPrevious;
   std::vector<int> vGoodBC;
   std::vector<int> vMediumBC;
   std::vector<int> vBadBC;

Modules/CTP/src/CTPTrendingTask.cxx

@@ -127,7 +127,6 @@ void CTPTrendingTask::trendValues(const Trigger& t, repository::DatabaseInterfac
       ILOG(Info, Support) << "no MO object" << ENDM;
       continue;
     }
-    ILOG(Info, Support) << "Got MO " << mo << ENDM;
     TObject* obj = mo ? mo->getObject() : nullptr;
     if (!obj) {
       ILOG(Info, Support) << "inputs not found" << ENDM;
@@ -154,7 +153,11 @@ void CTPTrendingTask::generatePlots()
     return;
   }
 
-  int index = 0;
+  int index = 0; // for keeping track what is trended:
+                 // 0 <= index < 5 - absolute input rates are trended
+                 // 5 <= index < 10 - absolute class rates are trended
+                 // 10 <= index < 15 - input rate ratios are trended
+                 // 15 <= index < 19 - class rate ratios are trended
 
   for (const auto& plot : mConfig.plots) {
 
@@ -165,24 +168,40 @@ void CTPTrendingTask::generatePlots()
       delete mPlots[plot.name];
     }
 
-    if (index > 4 && mClassIndex[index - 5] == 65) {
+    if (index > 4 && index < 10 && mClassIndex[index - 5] == 65) { // if the class index == 65, this class is not defined in the config, so it won't be trended
       ILOG(Info, Support) << "Class " << mClassNames[index - 5] << " is not trended." << ENDM;
       index++;
       continue;
     }
 
+    if (index > 13 && (mClassIndex[index - 13] == 65 || mClassIndex[0] == 65)) { // if the class index == 65, this class is not defined in the config, so it won't be trended
+      ILOG(Info, Support) << "Class ratio " << mClassNames[index - 13] << " / " << mClassNames[0] << " is not trended." << ENDM;
+      index++;
+      continue;
+    }
+
     auto* c = new TCanvas();
     ILOG(Info, Support) << plot.varexp << " " << plot.selection << " " << plot.option << ENDM;
     mTrend->Draw(plot.varexp.c_str(), plot.selection.c_str(), plot.option.c_str());
 
     c->SetName(plot.name.c_str());
 
     if (auto histo = dynamic_cast<TH1*>(c->GetPrimitive("htemp"))) {
-      if (index < 5)
+      if (index < 5) {
         histo->SetTitle(mInputNames[index].c_str());
-      else
+      } else if (index < 10) {
         histo->SetTitle(mClassNames[index - 5].c_str());
-      histo->GetYaxis()->SetTitle("rate [Hz]");
+      } else if (index < 14) {
+        histo->SetTitle(Form("%s/%s", mInputNames[index - 9].c_str(), mInputNames[0].c_str()));
+      } else {
+        histo->SetTitle(Form("%s/%s", mClassNames[index - 13].c_str(), mClassNames[0].c_str()));
+      }
+
+      if (index < 10) {
+        histo->GetYaxis()->SetTitle("rate [Hz]");
+      } else {
+        histo->GetYaxis()->SetTitle("rate ratio");
+      }
       c->Update();
 
       if (plot.varexp.find(":time") != std::string::npos) {

Modules/CTP/src/RawDataQcTask.cxx

@@ -47,8 +47,12 @@ void CTPRawDataReaderTask::initialize(o2::framework::InitContext& /*ctx*/)
   mHistoInputs = new TH1F("inputs", "Inputs distribution", 48, 0, 48);
   mHistoClasses = new TH1F("classes", "Classes distribution", 65, 0, 65);
   mHistoMTVXBC = new TH1F("bcMTVX", "BC position of MTVX", 3564, 0, 3564);
+  mHistoInputRatios = new TH1F("inputRatio", "Input Ratio distribution", 48, 0, 48);
+  mHistoClassRatios = new TH1F("classRatio", "Class Ratio distribution", 65, 0, 65);
   getObjectsManager()->startPublishing(mHistoInputs);
   getObjectsManager()->startPublishing(mHistoClasses);
+  getObjectsManager()->startPublishing(mHistoClassRatios);
+  getObjectsManager()->startPublishing(mHistoInputRatios);
   getObjectsManager()->startPublishing(mHistoMTVXBC);
 
   mDecoder.setDoLumi(1);
@@ -60,6 +64,8 @@ void CTPRawDataReaderTask::startOfActivity(const Activity& activity)
   ILOG(Debug, Devel) << "startOfActivity " << activity.mId << ENDM;
   mHistoInputs->Reset();
   mHistoClasses->Reset();
+  mHistoClassRatios->Reset();
+  mHistoInputRatios->Reset();
   mHistoMTVXBC->Reset();
 }
 
@@ -88,6 +94,7 @@ void CTPRawDataReaderTask::monitorData(o2::framework::ProcessingContext& ctx)
       for (int i = 0; i < o2::ctp::CTP_NINPUTS; i++) {
         if (digit.CTPInputMask[i]) {
           mHistoInputs->Fill(i);
+          mHistoInputRatios->Fill(i);
           if (i == indexTvx - 1)
             mHistoMTVXBC->Fill(bcid);
         }
@@ -97,6 +104,7 @@ void CTPRawDataReaderTask::monitorData(o2::framework::ProcessingContext& ctx)
       for (int i = 0; i < o2::ctp::CTP_NCLASSES; i++) {
         if (digit.CTPClassMask[i]) {
           mHistoClasses->Fill(i);
+          mHistoClassRatios->Fill(i);
         }
       }
     }
@@ -120,6 +128,8 @@ void CTPRawDataReaderTask::reset()
   ILOG(Debug, Devel) << "Resetting the histograms" << ENDM;
   mHistoInputs->Reset();
   mHistoClasses->Reset();
+  mHistoInputRatios->Reset();
+  mHistoClassRatios->Reset();
   mHistoMTVXBC->Reset();
 }