ITS Checks: updates for NClustersPerTrack and FHR_Occupancy MOs (#1761)

* ITS Checks: updates for NClustersPerTrack and FHROccupancy MOs

* clang

* Ivan's comments

Author: IsakovAD

Modules/ITS/src/ITSFhrCheck.cxx

@@ -27,6 +27,7 @@
 #include <TH2Poly.h>
 #include <TString.h>
 #include "Common/Utils.h"
+#include "TMath.h"
 
 namespace o2::quality_control_modules::its
 {
@@ -50,35 +51,54 @@ Quality ITSFhrCheck::check(std::map<std::string, std::shared_ptr<MonitorObject>>
       result.addMetadata("Gen_Occu_empty", "good");
       result.set(Quality::Good);
       std::vector<int> skipbins = convertToIntArray(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "skipbins", ""));
-      for (int ibin = 1; ibin <= h->GetNumberOfBins(); ibin++) {
-        if (ibin <= 48) { // IB
+
+      TIter next(h->GetBins());
+      int ibin = 0;
+      double_t nBadStaves[4];
+
+      while (TH2PolyBin* Bin = (TH2PolyBin*)next()) {
+
+        if (std::find(skipbins.begin(), skipbins.end(), ibin) != skipbins.end()) {
+          ibin++;
+          continue;
+        }
+
+        double X_center = (Bin->GetXMax() + Bin->GetXMin()) / 2;
+        double Y_center = (Bin->GetYMax() + Bin->GetYMin()) / 2;
+        double phi = TMath::ATan2(Y_center, X_center);
+        int sector = 2 * (phi + TMath::Pi()) / TMath::Pi();
+
+        if (ibin < 48) { // IB
           fhrcutIB = o2::quality_control_modules::common::getFromConfig<float>(mCustomParameters, "fhrcutIB", fhrcutIB);
           if (h->GetBinContent(ibin) > fhrcutIB) {
-            if (std::find(skipbins.begin(), skipbins.end(), ibin) != skipbins.end()) {
-              continue;
-            }
             result.updateMetadata("Gen_Occu_IB", "bad");
             result.set(Quality::Bad);
           }
         } else { // OB
           fhrcutOB = o2::quality_control_modules::common::getFromConfig<float>(mCustomParameters, "fhrcutOB", fhrcutOB);
           if (h->GetBinContent(ibin) > fhrcutOB) {
-            if (std::find(skipbins.begin(), skipbins.end(), ibin) != skipbins.end()) {
-              continue;
-            }
             result.updateMetadata("Gen_Occu_OB", "bad");
             result.set(Quality::Bad);
           }
         }
 
-        if (h->GetBinContent(ibin) < 1e-15) { // in case of empty stave
-          if (std::find(skipbins.begin(), skipbins.end(), ibin) != skipbins.end()) {
-            continue;
-          }
+        if (Bin->GetContent() < 1e-15) { // in case of empty stave
+          nBadStaves[sector]++;
+        }
+        ibin++;
+      }
+
+      for (int iSector = 0; iSector < 4; iSector++) {
+        if (nBadStaves[iSector] / 48 > 0.1) {
           result.updateMetadata("Gen_Occu_empty", "bad");
           result.set(Quality::Bad);
+          break;
+        } else if (nBadStaves[iSector] / 48 > 0.05) {
+          result.updateMetadata("Gen_Occu_empty", "medium");
+          result.set(Quality::Medium);
         }
-      } // end loop on bins
+      }
+
     } else if (mo->getName() == "General/Noisy_Pixel") {
       auto* h = dynamic_cast<TH2Poly*>(mo->getObject());
       result.addMetadata("Noi_Pix", "good");
@@ -183,12 +203,19 @@ void ITSFhrCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResul
       h->GetListOfFunctions()->Add(tInfo[1]->Clone());
     }
     if (strcmp(checkResult.getMetadata("Gen_Occu_empty").c_str(), "bad") == 0) {
-      tInfo[2] = std::make_shared<TLatex>(0.4, 0.3, "#splitline{There are staves without hits}{IGNORE them if run has just started OR if it's TECH RUN}");
+      tInfo[2] = std::make_shared<TLatex>(0.4, 0.3, "#splitline{ITS sector has more than 10% of empty staves}{IGNORE them if run has just started OR if it's TECH RUN}");
       tInfo[2]->SetTextColor(kRed);
       tInfo[2]->SetTextSize(0.03);
       tInfo[2]->SetTextFont(43);
       tInfo[2]->SetNDC();
       h->GetListOfFunctions()->Add(tInfo[2]->Clone());
+    } else if (strcmp(checkResult.getMetadata("Gen_Occu_empty").c_str(), "medium") == 0) {
+      tInfo[2] = std::make_shared<TLatex>(0.4, 0.3, "#splitline{ITS sector has more than 5% of empty staves}{IGNORE them if run has just started OR if it's TECH RUN}");
+      tInfo[2]->SetTextColor(kOrange);
+      tInfo[2]->SetTextSize(0.03);
+      tInfo[2]->SetTextFont(43);
+      tInfo[2]->SetNDC();
+      h->GetListOfFunctions()->Add(tInfo[2]->Clone());
     }
 
     tInfo[3] = std::make_shared<TLatex>(0.12, 0.835, Form("#bf{%s}", status.Data()));

Modules/ITS/src/ITSTrackCheck.cxx

@@ -45,6 +45,7 @@ Quality ITSTrackCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
       result.addMetadata("CheckTracks6", "good");
       result.addMetadata("CheckTracks7", "good");
       result.addMetadata("CheckEmpty", "good");
+      result.addMetadata("CheckMean", "good");
       if (h->GetBinContent(h->FindBin(4)) < 1e-15) {
         result.updateMetadata("CheckTracks4", "bad");
         result.set(Quality::Bad);
@@ -65,6 +66,11 @@ Quality ITSTrackCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
         result.updateMetadata("CheckEmpty", "bad");
         result.set(Quality::Bad);
       }
+      if (h->GetMean() < 5.2 || h->GetMean() > 5.8) {
+
+        result.updateMetadata("CheckMean", "medium");
+        result.set(Quality::Medium);
+      }
     }
 
     if (iter->second->getName() == "AngularDistribution") {
@@ -217,6 +223,16 @@ void ITSTrackCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkRes
         tMessage[4]->SetNDC();
         h->GetListOfFunctions()->Add(tMessage[4]->Clone());
       }
+      if (strcmp(checkResult.getMetadata("CheckMean").c_str(), "medium") == 0) {
+        status = "";
+        textColor = kOrange;
+        tMessage[5] = std::make_shared<TLatex>(0.12, 0.7, Form("Quality::Medium: Mean (%.1f) is outside of 5.2 - 5.9,  (ignore for COSMICS and TECHICALS", h->GetMean()));
+        tMessage[5]->SetTextFont(43);
+        tMessage[5]->SetTextSize(0.04);
+        tMessage[5]->SetTextColor(kOrange);
+        tMessage[5]->SetNDC();
+        h->GetListOfFunctions()->Add(tMessage[5]->Clone());
+      }
     }
 
     tInfo = std::make_shared<TLatex>(0.12, 0.75, Form("#bf{%s}", status.Data()));