Set proper ownership of MO collection after deserialization (#798)

Author: knopers8

Framework/include/QualityControl/MonitorObjectCollection.h

@@ -30,6 +30,9 @@ class MonitorObjectCollection : public TObjArray, public mergers::MergeInterface
   ~MonitorObjectCollection() = default;
 
   void merge(mergers::MergeInterface* const other) override;
+
+  void postDeserialization() override;
+
   ClassDefOverride(MonitorObjectCollection, 0);
 };
 

Framework/src/CheckRunner.cxx

@@ -243,11 +243,12 @@ void CheckRunner::prepareCacheData(framework::InputRecord& inputRecord)
 
       // We don't know what we receive, so we test for an array and then try a tobject.
       // If we received a tobject, it gets encapsulated in the tobjarray.
-      shared_ptr<const TObjArray> array = nullptr;
-      shared_ptr<const TObject> tobj = inputRecord.get<TObject*>(input.binding.c_str());
+      shared_ptr<TObjArray> array = nullptr;
+      auto tobj = DataRefUtils::as<TObject>(dataRef);
       // if the object has not been found, it will raise an exception that we just let go.
       if (tobj->InheritsFrom("TObjArray")) {
-        array = dynamic_pointer_cast<const TObjArray>(tobj);
+        array.reset(dynamic_cast<TObjArray*>(tobj.release()));
+        array->SetOwner(false);
         mLogger << AliceO2::InfoLogger::InfoLogger::Info << "CheckRunner " << mDeviceName
                 << " received an array with " << array->GetEntries()
                 << " entries from " << input.binding << ENDM;

Framework/src/MonitorObjectCollection.cxx

@@ -15,8 +15,8 @@
 ///
 
 #include "QualityControl/MonitorObjectCollection.h"
-
 #include "QualityControl/MonitorObject.h"
+#include "QualityControl/QcInfoLogger.h"
 
 #include <Mergers/MergerAlgorithm.h>
 
@@ -51,4 +51,23 @@ void MonitorObjectCollection::merge(mergers::MergeInterface* const other)
   delete otherIterator;
 }
 
+void MonitorObjectCollection::postDeserialization()
+{
+  auto it = this->MakeIterator();
+  while (auto obj = it->Next()) {
+    auto mo = dynamic_cast<MonitorObject*>(obj);
+    if (mo == nullptr) {
+      ILOG(Warning) << "Could not cast an object of type '" << obj->ClassName() << "' in MonitorObjectCollection to MonitorObject, skipping." << ENDM;
+      continue;
+    }
+    mo->setIsOwner(true);
+    if (mo->getObject() != nullptr && mo->getObject()->InheritsFrom(TCollection::Class())) {
+      auto collection = dynamic_cast<TCollection*>(mo->getObject());
+      collection->SetOwner(true);
+    }
+  }
+  this->SetOwner(true);
+  delete it;
+}
+
 } // namespace o2::quality_control::core

Framework/src/ObjectsManager.cxx

@@ -53,7 +53,7 @@ ObjectsManager::~ObjectsManager() = default;
 
 void ObjectsManager::startPublishing(TObject* object)
 {
-  if (mMonitorObjects->FindObject(object->GetName()) != 0) {
+  if (mMonitorObjects->FindObject(object->GetName()) != nullptr) {
     ILOG(Warning, Support) << "Object is already being published (" << object->GetName() << ")" << ENDM;
     BOOST_THROW_EXCEPTION(DuplicateObjectError() << errinfo_object_name(object->GetName()));
   }