Revert "[QC-1031]: changed origin for QC Check (#2170)" (#2181)

This reverts commit cd342d8.

Author: knopers8

Framework/include/QualityControl/Check.h

@@ -79,18 +79,13 @@ class Check
   // TODO: Unique Input string
   static o2::header::DataDescription createCheckDataDescription(const std::string& checkName);
 
-  /// \brief creates DataOrigin for Check task in form CDET
-  ///
-  /// \param detector Name of the detector to be used. If longer than 3B it will be truncated
-  static o2::header::DataOrigin createCheckDataOrigin(const std::string& detector);
-
   UpdatePolicyType getUpdatePolicyType() const;
   std::vector<std::string> getObjectsNames() const;
   bool getAllObjectsOption() const;
 
   // todo: probably make CheckFactory
   static CheckConfig extractConfig(const core::CommonSpec&, const CheckSpec&);
-  static framework::OutputSpec createOutputSpec(const std::string& detector, const std::string& checkName);
+  static framework::OutputSpec createOutputSpec(const std::string& checkName);
 
  private:
   void beautify(std::map<std::string, std::shared_ptr<core::MonitorObject>>& moMap, const core::Quality& quality);

Framework/src/Check.cxx

@@ -53,14 +53,6 @@ o2::header::DataDescription Check::createCheckDataDescription(const std::string&
   return quality_control::core::createDataDescription(checkName, Check::descriptionHashLength);
 }
 
-o2::header::DataOrigin Check::createCheckDataOrigin(const std::string& detector)
-{
-  using Origin = o2::header::DataOrigin;
-  Origin header;
-  header.runtimeInit(std::string{ "C" }.append(detector.substr(0, Origin::size - 1)).c_str());
-  return header;
-}
-
 /// Members
 Check::Check(CheckConfig config)
   : mCheckConfig(std::move(config))
@@ -268,14 +260,14 @@ CheckConfig Check::extractConfig(const CommonSpec& commonSpec, const CheckSpec&
     checkAllObjects,
     allowBeautify,
     std::move(inputs),
-    createOutputSpec(checkSpec.detectorName, checkSpec.checkName),
+    createOutputSpec(checkSpec.checkName),
     commonSpec.conditionDBUrl
   };
 }
 
-framework::OutputSpec Check::createOutputSpec(const std::string& detector, const std::string& checkName)
+framework::OutputSpec Check::createOutputSpec(const std::string& checkName)
 {
-  return { createCheckDataOrigin(detector), createCheckDataDescription(checkName), 0, framework::Lifetime::Sporadic };
+  return { "QC", createCheckDataDescription(checkName), 0, framework::Lifetime::Sporadic };
 }
 
 void Check::startOfActivity(const core::Activity& activity)

Framework/test/testCheck.cxx

@@ -66,7 +66,7 @@ BOOST_AUTO_TEST_CASE(test_check_specs)
   BOOST_REQUIRE_EQUAL(check.getInputs().size(), 1);
   BOOST_CHECK_EQUAL(check.getInputs()[0], (InputSpec{ { "mo" }, "QTST", "skeletonTask", 0, Lifetime::Sporadic }));
 
-  BOOST_CHECK_EQUAL(check.getOutputSpec(), (OutputSpec{ "CDET", "singleCheck", 0, Lifetime::Sporadic }));
+  BOOST_CHECK_EQUAL(check.getOutputSpec(), (OutputSpec{ "QC", "singleCheck", 0, Lifetime::Sporadic }));
 }
 
 BOOST_AUTO_TEST_CASE(test_check_long_description)
@@ -78,7 +78,7 @@ BOOST_AUTO_TEST_CASE(test_check_long_description)
   BOOST_REQUIRE_EQUAL(check.getInputs().size(), 1);
   BOOST_CHECK_EQUAL(check.getInputs()[0], (InputSpec{ { "mo" }, "QTST", "skeletonTask", 0, Lifetime::Sporadic }));
 
-  BOOST_CHECK_EQUAL(check.getOutputSpec(), (OutputSpec{ "CDET", "singleCheckL9fdb", 0, Lifetime::Sporadic }));
+  BOOST_CHECK_EQUAL(check.getOutputSpec(), (OutputSpec{ "QC", "singleCheckL9fdb", 0, Lifetime::Sporadic }));
 }
 
 std::shared_ptr<MonitorObject> dummyMO(const std::string& objName)

Framework/test/testCheckWorkflow.cxx

@@ -110,7 +110,7 @@ class Receiver : public framework::Task
   {
     Inputs inputs;
     for (auto& checkName : mNames) {
-      inputs.push_back({ checkName, "CTST", Check::createCheckDataDescription(checkName), Lifetime::Sporadic });
+      inputs.push_back({ checkName, "QC", Check::createCheckDataDescription(checkName), Lifetime::Sporadic });
     }
     return inputs;
   }

Framework/test/testWorkflow.cxx

@@ -74,7 +74,7 @@ WorkflowSpec defineDataProcessing(ConfigContext const&)
   DataProcessorSpec receiver{
     "receiver",
     Inputs{
-      { "checked-mo", "CTST", Check::createCheckDataDescription(getFirstCheckName(qcConfigurationSource)), 0, Lifetime::Sporadic } },
+      { "checked-mo", "QC", Check::createCheckDataDescription(getFirstCheckName(qcConfigurationSource)), 0, Lifetime::Sporadic } },
     Outputs{},
     AlgorithmSpec{
       [](ProcessingContext& pctx) {