TPC: Update Reductor for PID SepPower to new data format (#2345)

* TPC Reductor PID Separation Power

Author: mlesch

Modules/TPC/include/TPC/SeparationPowerReductor.h

@@ -17,7 +17,6 @@
 #define QC_MODULE_TPC_SEPARATIONPOWERREDUCTOR_H
 
 #include "QualityControl/ReductorTObject.h"
-#include <TText.h>
 
 namespace o2::quality_control_modules::tpc
 {
@@ -37,12 +36,15 @@ class SeparationPowerReductor : public quality_control::postprocessing::Reductor
 
  private:
   struct {
+    float amplitudePi;
     float meanPi;
+    float sigmaPi;
+    float amplitudeEl;
     float meanEl;
+    float sigmaEl;
     float separationPower;
+    float chiSquareOverNdf;
   } mSeparationPower;
-
-  float getValue(TText* line);
 };
 
 } // namespace o2::quality_control_modules::tpc

Modules/TPC/run/tpcQCTrending_separationpower.json

@@ -33,7 +33,7 @@
           {
             "type": "repository",
             "path": "TPC/MO/PID",
-            "name": "CSeparationPower",
+            "name": "pSeparationPower",
             "reductorName": "o2::quality_control_modules::tpc::SeparationPowerReductor",
             "moduleName": "QcTPC"
           }
@@ -42,23 +42,31 @@
           {
             "name": "sepPower_MeanPi",
             "title": "Trend of Separation Power Mean Pion",
-            "varexp": "CSeparationPower.meanPi:time",
+            "varexp": "pSeparationPower.meanPi:time",
             "selection": "",
             "option": "*L",
-            "graphErrors": ""
+            "graphErrors": "0:sigmaPi"
           },
           {
             "name": "sepPower_El",
             "title": "Trend of Separation Power Mean Electron",
-            "varexp": "CSeparationPower.meanEl:time",
+            "varexp": "pSeparationPower.meanEl:time",
             "selection": "",
             "option": "*L",
-            "graphErrors": ""
+            "graphErrors": "0:sigmaEl"
           },
           {
             "name": "sepPower_SeparationPower",
             "title": "Trend of SeparationPower",
-            "varexp": "CSeparationPower.separationPower:time",
+            "varexp": "pSeparationPower.separationPower:time",
+            "selection": "",
+            "option": "*L",
+            "graphErrors": ""
+          },
+          {
+            "name": "sepPower_ChiSquareOverNDF",
+            "title": "Trend of SeparationPower ChiSquare/NDF fit",
+            "varexp": "pSeparationPower.chiSquareOverNdf:time",
             "selection": "",
             "option": "*L",
             "graphErrors": ""
@@ -68,7 +76,7 @@
           "userorcontrol"
         ],
         "updateTrigger": [
-          "foreachlatest:ccdb:qc/TPC/MO/PID/CSeparationPower"
+          "foreachlatest:ccdb:qc/TPC/MO/PID/pSeparationPower"
         ],
         "stopTrigger": [
           "userorcontrol"

Modules/TPC/src/SeparationPowerReductor.cxx

@@ -17,8 +17,7 @@
 #include "QualityControl/QcInfoLogger.h"
 #include <boost/algorithm/string.hpp>
 #include <string>
-#include <TCanvas.h>
-#include <TPaveText.h>
+#include <TProfile.h>
 
 namespace o2::quality_control_modules::tpc
 {
@@ -30,36 +29,28 @@ void* SeparationPowerReductor::getBranchAddress()
 
 const char* SeparationPowerReductor::getBranchLeafList()
 {
-  return "meanPi/F:meanEl:separationPower";
+  return "amplitudePi/F:meanPi:sigmaPi:amplitudeEl:meanEl:sigmaEl:separationPower:chiSquareOverNdf";
 }
 
 void SeparationPowerReductor::update(TObject* obj)
 {
-  // The values for the separation power are saved in a TPaveText inside a TCanvas 'obj'.
+  // The values for the separation power are saved in a TProfile
   if (obj) {
-    if (auto canvas = static_cast<TCanvas*>(obj)) {
-      if (auto blocText = static_cast<TPaveText*>(canvas->GetPrimitive("TPave"))) {
-        mSeparationPower.meanPi = getValue((TText*)blocText->GetLineWith("Mean Pi:"));
-        mSeparationPower.meanEl = getValue((TText*)blocText->GetLineWith("Mean El:"));
-        mSeparationPower.separationPower = getValue((TText*)blocText->GetLineWith("separationPower:"));
-      }
+    if (auto profile = static_cast<TProfile*>(obj)) {
+      mSeparationPower.amplitudePi = profile->GetBinContent(1);
+      mSeparationPower.meanPi = profile->GetBinContent(2);
+      mSeparationPower.sigmaPi = profile->GetBinContent(3);
+
+      mSeparationPower.amplitudeEl = profile->GetBinContent(4);
+      mSeparationPower.meanEl = profile->GetBinContent(5);
+      mSeparationPower.sigmaEl = profile->GetBinContent(6);
+
+      mSeparationPower.separationPower = profile->GetBinContent(7);
+      mSeparationPower.chiSquareOverNdf = profile->GetBinContent(8);
     }
   } else {
     ILOG(Error, Support) << "No 'obj' found." << ENDM;
   }
 }
 
-float SeparationPowerReductor::getValue(TText* line)
-{
-  if (!line) {
-    return 0.;
-  }
-
-  std::string text = static_cast<std::string>(line->GetTitle());
-  const std::size_t posEndType = text.find(":");
-  std::string quantity = text.substr(posEndType + 2, -1); // take string (excluding : and empty space) till end of line
-
-  return stof(quantity);
-}
-
 } // namespace o2::quality_control_modules::tpc