Skip to content

Commit c17294a

Browse files
committed
update readme
1 parent cf8feea commit c17294a

1 file changed

Lines changed: 12 additions & 9 deletions

File tree

README.md

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,9 @@ A Linux machine (CC7 or Ubuntu) or a Mac. See the O2 instructions below for the
5757
4. Build/install the QualityControl, its GUI (qcg) and the readout. The simplest is to use the metapackage `flpproto`.
5858
* `aliBuild build flpproto --default o2`
5959

60-
5. Install GLFW to have GUIs in the DPL (optional). On CC7 install `glfw-devel` from epel repository:
61-
* `sudo yum install glfw-devel --enablerepo=epel`
60+
5. Install GLFW to have GUIs in the DPL (optional, DPL GUIs do not work in containers).
61+
* On CC7 : `sudo yum install glfw-devel --enablerepo=epel`
62+
* On Mac : `brew install glfw`
6263

6364
Note : you can also use the alibuild "defaults" called `o2-dataflow` to avoid building simulation related packages.
6465

@@ -223,13 +224,11 @@ Data Sampling is used by Quality Control to feed the tasks with data. Below we p
223224
{
224225
"qc": {
225226
...
226-
"tasks_config": {
227+
"tasks": {
227228
"QcTask": {
228-
"taskDefinition": "QcTaskDefinition"
229-
},
230-
"QcTaskDefinition": {
231229
...
232-
"dataSamplingPolicy": "its-raw"
230+
"dataSamplingPolicy": "its-raw",
231+
...
233232
}
234233
}
235234
},
@@ -311,7 +310,7 @@ Now that there is a module, we can build it and test it. First let's build it :
311310
# We are in ~/alice
312311
# Go to the build directory of QualityControl
313312
cd sw/slc7_x86-64/BUILD/QualityControl-latest/QualityControl
314-
make -j8 install
313+
make -j8 install # replace 8 by the number of cores on your machine
315314
```
316315

317316
To test whether it works, we are going to run a basic DPL workflow defined in `runBasic.cxx`.
@@ -320,7 +319,7 @@ The config file is called `basic.json` and is located in `$QUALITY_CONTROL/etc/`
320319
Change the lines as indicated below :
321320

322321
```
323-
"QcTaskDefinition": {
322+
"QcTask": {
324323
"className": "o2::quality_control_modules::abc::RawDataQcTask",
325324
"moduleName": "QcAbc",
326325
```
@@ -350,6 +349,10 @@ If you want to change the workflow, edit or copy `runBasic.cxx`. For example...
350349

351350
TODO
352351

352+
## Plugging an existing DPL workflow into the Data Sampling and QC
353+
354+
TODO
355+
353356
## Commit Code
354357

355358
To commit your new or modified code, please follow this procedure

0 commit comments

Comments
 (0)