[QC-984] Fix pp finalize no init (#1834)

* [QC-984] nullptr if finalize is called before initialize

* format

* do not finalize if it is not initialized.

* actually fix

* format

Author: Barthelemy

Framework/src/PostProcessingRunner.cxx

@@ -237,6 +237,10 @@ void PostProcessingRunner::doUpdate(const Trigger& trigger)
 
 void PostProcessingRunner::doFinalize(const Trigger& trigger)
 {
+  if (mTaskState != TaskState::Running) {
+    ILOG(Warning, Support) << "Attempt at finalizing the user task although it was not initialized. Skipping the finalization." << ENDM;
+    return;
+  }
   ILOG(Info, Support) << "Finalizing the user task due to trigger '" << trigger << "'" << ENDM;
   mTask->finalize(trigger, mServices);
   mObjectManager->setValidity(ValidityInterval{ trigger.timestamp, trigger.timestamp + objectValidity });

Framework/src/SliceTrendingTask.cxx

@@ -151,6 +151,11 @@ void SliceTrendingTask::trendValues(const Trigger& t,
 
 void SliceTrendingTask::generatePlots()
 {
+  if (mTrend == nullptr) {
+    ILOG(Info, Support) << "The trend object is not there, won't generate any plots." << ENDM;
+    return;
+  }
+
   if (mTrend->GetEntries() < 1) {
     ILOG(Info, Support) << "No entries in the trend so far, no plot generated." << ENDM;
     return;

Framework/src/TrendingTask.cxx

@@ -199,6 +199,11 @@ void TrendingTask::setUserYAxisRange(TH1* hist, const std::string& graphYAxisRan
 
 void TrendingTask::generatePlots()
 {
+  if (mTrend == nullptr) {
+    ILOG(Info, Support) << "The trend object is not there, won't generate any plots." << ENDM;
+    return;
+  }
+
   if (mTrend->GetEntries() < 1) {
     ILOG(Info, Support) << "No entries in the trend so far, won't generate any plots." << ENDM;
     return;