QC checks review first round - update for shifters' plots (#1377)

iravasen · web-flow · commit d652781a3ff7 · 2022-08-09T07:42:47.000+02:00
* QC checks review first round - update for shifters' plots

* reintroduced normal params in jsons

* solved trivial issue with macOS build

* change bad to medium for lane overview
diff --git a/Modules/ITS/include/ITS/ITSClusterCheck.h b/Modules/ITS/include/ITS/ITSClusterCheck.h
@@ -22,6 +22,9 @@
 #include "QualityControl/CheckInterface.h"
 #include <TLatex.h>
 #include <TH2Poly.h>
+#include <vector>
+#include <string>
+#include <sstream>
 
 namespace o2::quality_control_modules::its
 {
@@ -41,11 +44,14 @@ class ITSClusterCheck : public o2::quality_control::checker::CheckInterface
   Quality check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap) override;
   void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;
   std::string getAcceptedType() override;
+  std::vector<int> convertToIntArray(std::string input);
 
  private:
   ClassDefOverride(ITSClusterCheck, 2);
 
   std::shared_ptr<TLatex> msg;
+  std::shared_ptr<TLatex> text[14];
+  std::shared_ptr<TLatex> text2[14];
   static constexpr int NLayer = 7;
   const int mNStaves[NLayer] = { 12, 16, 20, 24, 30, 42, 48 };
   const int StaveBoundary[NLayer + 1] = { 0, 12, 28, 48, 72, 102, 144, 192 };
diff --git a/Modules/ITS/include/ITS/ITSFeeCheck.h b/Modules/ITS/include/ITS/ITSFeeCheck.h
@@ -22,6 +22,9 @@
 #include "QualityControl/CheckInterface.h"
 #include <TH2Poly.h>
 #include <TLatex.h>
+#include <string>
+#include <vector>
+#include <sstream>
 
 namespace o2::quality_control_modules::its
 {
@@ -41,6 +44,7 @@ class ITSFeeCheck : public o2::quality_control::checker::CheckInterface
   Quality check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap) override;
   void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;
   std::string getAcceptedType() override;
+  std::vector<int> convertToIntArray(std::string input);
 
  private:
   ClassDefOverride(ITSFeeCheck, 2);
@@ -50,19 +54,19 @@ class ITSFeeCheck : public o2::quality_control::checker::CheckInterface
   const int NLanePerStaveLayer[NLayer] = { 9, 9, 9, 16, 16, 28, 28 };
   const int NStaves[NLayer] = { 12, 16, 20, 24, 30, 42, 48 };
   static constexpr int NFlags = 3;
+  static constexpr int NTrg = 13;
   const double minTextPosY[NLayer] = { 0.45, 0.41, 0.37, 0.23, 0.20, 0.16, 0.13 }; // Text y coordinates in TH2Poly
   std::string mLaneStatusFlag[NFlags] = { "WARNING", "ERROR", "FAULT" };
-  static constexpr int NSummary = 4;
-  std::string mSummaryPlots[NSummary] = { "Global", "IB", "ML", "OL" };
-  const int laneMaxSummaryPlots[NSummary] = { 3816, 1, 864, 2520 };
   const int laneMax[NLayer] = { 108, 144, 180, 384, 480, 1176, 1344 };
 
   std::shared_ptr<TLatex> tInfo;
   std::shared_ptr<TLatex> tInfoLayers[7];
   std::shared_ptr<TLatex> tInfoIB;
   std::shared_ptr<TLatex> tInfoML;
   std::shared_ptr<TLatex> tInfoOL;
-  std::shared_ptr<TLatex> tInfoSummary[4];
+  std::shared_ptr<TLatex> tInfoPL[10];
+  std::shared_ptr<TLatex> tInfoSummary;
+  std::shared_ptr<TLatex> tInfoTrg[13];
 };
 
 } // namespace o2::quality_control_modules::its
diff --git a/Modules/ITS/include/ITS/ITSFhrCheck.h b/Modules/ITS/include/ITS/ITSFhrCheck.h
@@ -19,6 +19,10 @@
 #define QC_MODULE_ITS_ITSFHRCHECK_H
 
 #include "QualityControl/CheckInterface.h"
+#include <string>
+#include <vector>
+#include <sstream>
+#include <TLatex.h>
 
 namespace o2::quality_control_modules::its
 {
@@ -38,9 +42,11 @@ class ITSFhrCheck : public o2::quality_control::checker::CheckInterface
   Quality check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap) override;
   void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;
   std::string getAcceptedType() override;
+  std::vector<int> convertToIntArray(std::string input);
 
  private:
   int mNPixelPerStave[3] = { 4718592, 58720256, 102760448 }; // IB, ML, OL
+  std::shared_ptr<TLatex> tInfo[5];
   ClassDefOverride(ITSFhrCheck, 2);
 };
 
diff --git a/Modules/ITS/include/ITS/ITSTrackCheck.h b/Modules/ITS/include/ITS/ITSTrackCheck.h
@@ -19,6 +19,7 @@
 #define QC_MODULE_ITS_ITSTRACKCHECK_H
 
 #include "QualityControl/CheckInterface.h"
+#include <TLatex.h>
 
 namespace o2::quality_control_modules::its
 {
@@ -41,6 +42,8 @@ class ITSTrackCheck : public o2::quality_control::checker::CheckInterface
   int getDigit(int number, int digit);
 
  private:
+  std::shared_ptr<TLatex> tInfo;
+  std::shared_ptr<TLatex> tMessage[10];
   ClassDefOverride(ITSTrackCheck, 2);
 };
 
diff --git a/Modules/ITS/itsCluster.json b/Modules/ITS/itsCluster.json
@@ -54,6 +54,17 @@
         "moduleName": "QcITS",
         "policy": "OnEachSeparately",
         "detectorName": "ITS",
+        "checkParameters": {
+          "maxcluoccL0" : "5",
+          "maxcluoccL1" : "4",
+          "maxcluoccL2" : "3",
+          "maxcluoccL3" : "2",
+          "maxcluoccL4" : "1",
+          "maxcluoccL5" : "1",
+          "maxcluoccL6" : "1",
+          "skipxbinsoccupancy" : "",
+          "skipybinsoccupancy" : ""
+        },
         "dataSource": [{
           "type": "Task",
           "name": "ITSClusterTask",
diff --git a/Modules/ITS/itsFee.json b/Modules/ITS/itsFee.json
@@ -3,7 +3,7 @@
         "config": {
             "database": {
                 "implementation": "CCDB",
-                "host": "ccdb-test.cern.ch:8080",
+                "host": ":188.184.2.55:8080",
                 "username": "not_applicable",
                 "password": "not_applicable",
                 "name": "not_applicable"
@@ -19,7 +19,7 @@
                 "url": ""
             },
             "conditionDB": {
-                "url": "ccdb-test.cern.ch:8080"
+                "url": "188.184.2.55:8080"
             }
         },
         "tasks": {
@@ -47,6 +47,14 @@
                 "moduleName": "QcITS",
                 "policy": "OnEachSeparately",
                 "detectorName": "ITS",
+                "checkParameters": {
+                  "skipbinstrg": "",
+                  "skipfeeids": "",
+                  "maxbadchipsIB": "2",
+                  "maxbadlanesML": "4",
+                  "maxbadlanesOL": "7",
+                  "maxfractionbadlanes": "0.1"
+                },
                 "dataSource": [
                     {
                         "type": "Task",
@@ -59,10 +67,9 @@
                             "LaneStatus/laneStatusOverviewFlagERROR",
                             "LaneStatus/laneStatusOverviewFlagWARNING",
                             "LaneStatusSummary/LaneStatusSummaryGlobal",
-                            "LaneStatusSummary/LaneStatusSummaryIB",
-                            "LaneStatusSummary/LaneStatusSummaryML",
-                            "LaneStatusSummary/LaneStatusSummaryOL",
-                            "RDHSummary"
+                            "RDHSummary",
+                            "TriggerVsFeeid",
+                            "PayloadSize"
                         ]
                     }
                 ]
diff --git a/Modules/ITS/itsFhr.json b/Modules/ITS/itsFhr.json
@@ -3,7 +3,7 @@
         "config": {
             "database": {
                 "implementation": "CCDB",
-                "host": "ccdb-test.cern.ch:8080",
+                "host": "188.184.2.55:8080",
                 "username": "not_applicable",
                 "password": "not_applicable",
                 "name": "not_applicable"
@@ -19,7 +19,7 @@
                 "url": ""
             },
             "conditionDB": {
-                "url": "ccdb-test.cern.ch:8080"
+                "url": "188.184.2.55:8080"
             }
         },
         "tasks": {
@@ -60,6 +60,11 @@
                 "moduleName": "QcITS",
                 "policy": "OnEachSeparately",
                 "detectorName": "ITS",
+                "checkParameters": {
+                    "fhrcutIB": "0.01",
+                    "fhrcutOB": "0.0001",
+                    "skipbins": ""
+                },
                 "dataSource": [{
                     "type": "Task",
                     "name": "FHRTask",
diff --git a/Modules/ITS/itsTrack.json b/Modules/ITS/itsTrack.json
@@ -53,7 +53,7 @@
         "active" : "true",
         "className" : "o2::quality_control_modules::its::ITSTrackCheck",
         "moduleName" : "QcITS",
-        "policy" : "OnAny",
+        "policy" : "OnEachSeparately",
         "detectorName" : "ITS",
         "dataSource" : [ {
           "type" : "Task",
diff --git a/Modules/ITS/src/ITSClusterCheck.cxx b/Modules/ITS/src/ITSClusterCheck.cxx
@@ -33,7 +33,6 @@ Quality ITSClusterCheck::check(std::map<std::string, std::shared_ptr<MonitorObje
 {
   Quality result = Quality::Null;
   double averageClusterSizeLimit[NLayer] = { 5, 5, 5, 5, 5, 5, 5 };
-  double clusterOccupationLimit[NLayer] = { 40, 30, 20, 60, 25, 15, 14 };
 
   std::map<std::string, std::shared_ptr<MonitorObject>>::iterator iter;
   for (iter = moMap->begin(); iter != moMap->end(); ++iter) {
@@ -52,16 +51,48 @@ Quality ITSClusterCheck::check(std::map<std::string, std::shared_ptr<MonitorObje
 
     if (iter->second->getName().find("General_Occupancy") != std::string::npos) {
       auto* hp = dynamic_cast<TH2D*>(iter->second->getObject());
+      std::vector<int> skipxbins = convertToIntArray(mCustomParameters["skipxbinsoccupancy"]);
+      std::vector<int> skipybins = convertToIntArray(mCustomParameters["skipybinsoccupancy"]);
+      std::vector<std::pair<int, int>> xypairs;
+      for (int i = 0; i < (int)skipxbins.size(); i++) {
+        xypairs.push_back(std::make_pair(skipxbins[i], skipybins[i]));
+      }
+      result.set(Quality::Good);
       for (int iy = 1; iy <= hp->GetNbinsY(); iy++) {
         int ilayer = iy <= hp->GetNbinsY() / 2 ? hp->GetNbinsY() / 2 - iy : iy - hp->GetNbinsY() / 2 - 1;
         std::string tb = iy <= hp->GetNbinsY() / 2 ? "B" : "T";
         result.addMetadata(Form("Layer%d%s", ilayer, tb.c_str()), "good");
         for (int ix = 1; ix <= hp->GetNbinsX(); ix++) { // loop on staves
-          if (hp->GetBinContent(ix) > clusterOccupationLimit[ilayer]) {
+          if (std::find(xypairs.begin(), xypairs.end(), std::make_pair(ix, iy)) != xypairs.end()) {
+            continue;
+          }
+          if (hp->GetBinContent(ix, iy) > std::stod(mCustomParameters[Form("maxcluoccL%d", ilayer)])) {
             result.set(Quality::Medium);
             result.updateMetadata(Form("Layer%d%s", ilayer, tb.c_str()), "medium");
           }
         }
+        // check for empty bins (empty staves)
+        result.addMetadata(Form("Layer%d%s_empty", ilayer, tb.c_str()), "good");
+        for (int ix = 12; ix > 12 - mNStaves[ilayer] / 4; ix--) {
+          if (std::find(xypairs.begin(), xypairs.end(), std::make_pair(ix, iy)) != xypairs.end()) {
+            continue;
+          }
+          if (hp->GetBinContent(ix, iy) < 1e-15) {
+            result.updateMetadata(Form("Layer%d%s_empty", ilayer, tb.c_str()), "bad");
+            result.set(Quality::Bad);
+            LOG(info) << "************************ " << Form("Layer%d%s_empty", ilayer, tb.c_str());
+          }
+        }
+        int stop = (iy == 2 || iy == 13) ? 13 + mNStaves[ilayer] / 4 + 1 : 13 + mNStaves[ilayer] / 4; // for L5
+        for (int ix = 13; ix < stop; ix++) {
+          if (std::find(xypairs.begin(), xypairs.end(), std::make_pair(ix, iy)) != xypairs.end()) {
+            continue;
+          }
+          if (hp->GetBinContent(ix, iy) < 1e-15) {
+            result.updateMetadata(Form("Layer%d%s_empty", ilayer, tb.c_str()), "bad");
+            result.set(Quality::Bad);
+          }
+        }
       }
     } // end GeneralOccupancy
   }
@@ -74,7 +105,7 @@ std::string ITSClusterCheck::getAcceptedType() { return "TH2D"; }
 void ITSClusterCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
 {
 
-  TString text;
+  TString status;
   int textColor;
   Double_t positionX, positionY;
 
@@ -84,18 +115,18 @@ void ITSClusterCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkR
     int iLayer = histoName[histoName.find("Layer") + 5] - 48; // Searching for position of "Layer" in the name of the file, then +5 is the NUMBER of the layer, -48 is conversion to int
 
     if (checkResult == Quality::Medium) {
-      text = "INFO: large clusters - do not call expert";
+      status = "INFO: large clusters - do not call expert";
       textColor = kYellow;
       positionX = 0.15;
       positionY = 0.8;
     } else {
-      text = "Quality::GOOD";
+      status = "Quality::GOOD";
       textColor = kGreen;
       positionX = 0.02;
       positionY = 0.91;
     }
 
-    msg = std::make_shared<TLatex>(positionX, positionY, Form("#bf{%s}", text.Data()));
+    msg = std::make_shared<TLatex>(positionX, positionY, Form("#bf{%s}", status.Data()));
     msg->SetTextColor(textColor);
     msg->SetTextSize(0.06);
     msg->SetTextFont(43);
@@ -105,28 +136,62 @@ void ITSClusterCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkR
 
   if (mo->getName().find("General_Occupancy") != std::string::npos) {
     auto* h = dynamic_cast<TH2D*>(mo->getObject());
-
-    std::string histoName = mo->getName();
-
     if (checkResult == Quality::Good) {
-      text = "Quality::GOOD";
+      status = "Quality::GOOD";
       textColor = kGreen;
-      positionX = 0.02;
-      positionY = 0.91;
+      positionX = 0.12;
+      positionY = 0.75;
     } else {
-      text = "Large cluster occupancy - notify expert, do not call";
-      textColor = kYellow;
-      positionX = 0.15;
-      positionY = 0.8;
+      for (int il = 0; il < 14; il++) {
+        std::string tb = il < 7 ? "T" : "B";
+        if (strcmp(checkResult.getMetadata(Form("Layer%d%s", il % 7, tb.c_str())).c_str(), "medium") == 0) {
+          text[il] = std::make_shared<TLatex>(0.3, 0.1 + il * 0.05, Form("L%d%s has large cluster occupancy", il % 7, tb.c_str()));
+          text[il]->SetTextFont(43);
+          text[il]->SetTextSize(0.03);
+          text[il]->SetTextColor(kOrange);
+          text[il]->SetNDC();
+          h->GetListOfFunctions()->Add(text[il]->Clone());
+          status = "#splitline{Quality::Medium}{do NOT call, create log entry}";
+          textColor = kOrange;
+          positionX = 0.12;
+          positionY = 0.75;
+        }
+
+        if (strcmp(checkResult.getMetadata(Form("Layer%d%s_empty", il % 7, tb.c_str())).c_str(), "bad") == 0) {
+          text2[il] = std::make_shared<TLatex>(0.7, 0.1 + il * 0.05, Form("L%d%s has empty staves", il % 7, tb.c_str()));
+          text2[il]->SetTextFont(43);
+          text2[il]->SetTextSize(0.03);
+          text2[il]->SetTextColor(kRed);
+          text2[il]->SetNDC();
+          h->GetListOfFunctions()->Add(text2[il]->Clone());
+          status = "#splitline{Quality::Bad}{Call expert}";
+          textColor = kRed;
+          positionX = 0.12;
+          positionY = 0.75;
+        }
+      }
     }
-    msg = std::make_shared<TLatex>(positionX, positionY, Form("#bf{%s}", text.Data()));
+    msg = std::make_shared<TLatex>(positionX, positionY, Form("#bf{%s}", status.Data()));
     msg->SetTextColor(textColor);
-    msg->SetTextSize(0.06);
+    msg->SetTextSize(0.04);
     msg->SetTextFont(43);
     msg->SetNDC();
-
     h->GetListOfFunctions()->Add(msg->Clone());
   }
 }
 
+std::vector<int> ITSClusterCheck::convertToIntArray(std::string input)
+{
+  std::replace(input.begin(), input.end(), ',', ' ');
+  std::istringstream stringReader{ input };
+
+  std::vector<int> result;
+  int number;
+  while (stringReader >> number) {
+    result.push_back(number);
+  }
+
+  return result;
+}
+
 } // namespace o2::quality_control_modules::its
diff --git a/Modules/ITS/src/ITSFeeCheck.cxx b/Modules/ITS/src/ITSFeeCheck.cxx
diff --git a/Modules/ITS/src/ITSFhrCheck.cxx b/Modules/ITS/src/ITSFhrCheck.cxx
diff --git a/Modules/ITS/src/ITSTrackCheck.cxx b/Modules/ITS/src/ITSTrackCheck.cxx
