Skip to content

Commit e4b8708

Browse files
Barthelemyknopers8
authored andcommitted
Remove all references to curl as this is hidden away in CcdbApi
1 parent 1c194bb commit e4b8708

4 files changed

Lines changed: 3 additions & 8 deletions

File tree

Framework/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ target_link_libraries(
114114
Boost::system
115115
$<$<BOOL:${ENABLE_MYSQL}>:MySQL::MySQL>
116116
$<$<BOOL:${ENABLE_MYSQL}>:ROOT::RMySQL>
117-
CURL::CURL
118117
ROOT::Gui
119118
)
120119

Framework/include/QualityControl/CcdbDatabase.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@ namespace repository
2727
{
2828

2929
/*
30-
* Notes
30+
* Notes (also concerning the underlying CcdbApi)
3131
* - having 1 file per object per version server-side might lead to a tremendous number of files.
3232
* --> they are aware of it
3333
* - how to add a new filter ? such as expert/shifter flag
34-
* - we really need a C++ interface hiding the curl complexity.
34+
* --> new metadata
3535
* - what are those time intervals ? what does it mean for us ?
3636
* --> epoch milliseconds as long values
3737
* - how to know the real time at which the object was stored ?
@@ -45,7 +45,6 @@ namespace repository
4545
* --> doc has been udpated.
4646
* - initial tests show that it seems pretty slow.
4747
* --> ok on their server with the new metadata database (postgresql)
48-
* - We need getListOfTasksWithPublications() and getPublishedObjectNames()
4948
* - Current path to objects : .../task/object with object possibly a slash separated subpath (up to 6 levels). Also
5049
* consider having a task name such as "TPC/Task1" such as to build a tree of tasks with subsystems prefix.
5150
*

Framework/src/CcdbDatabase.cxx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,7 @@ std::string CcdbDatabase::retrieveJson(std::string taskName, std::string objectN
102102

103103
void CcdbDatabase::disconnect()
104104
{
105-
/* we're done with libcurl, so clean it up */
106-
curl_global_cleanup();
105+
// NOOP for CCDB
107106
}
108107

109108
void CcdbDatabase::prepareTaskDataContainer(std::string taskName)

Framework/test/testDbFactory.cxx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,13 @@
1414
#define BOOST_TEST_MAIN
1515
#define BOOST_TEST_DYN_LINK
1616

17-
#include "curl/curl.h"
1817
#include <boost/test/unit_test.hpp>
1918
#include <cassert>
2019
#include <iostream>
2120

2221
#include <QualityControl/CcdbDatabase.h>
2322
#include <QualityControl/MonitorObject.h>
2423
#include <TH1F.h>
25-
#include <curl/curl.h>
2624
#include <fcntl.h>
2725
#include <stdio.h>
2826
#include <sys/stat.h>

0 commit comments

Comments
 (0)