correction on Checks for Quality aggregator (#2232)

Author: ValerieRamillien

Modules/MUON/MID/src/ClustQcCheck.cxx

@@ -57,18 +57,22 @@ Quality ClustQcCheck::check(std::map<std::string, std::shared_ptr<MonitorObject>
     if (mo->getName() == "ClusterMap11") {
       auto* h2 = dynamic_cast<TH2F*>(mo->getObject());
       h2->Scale(scale);
+      result = Quality::Good;
     }
     if (mo->getName() == "ClusterMap12") {
       auto* h2 = dynamic_cast<TH2F*>(mo->getObject());
       h2->Scale(scale);
+      result = Quality::Good;
     }
     if (mo->getName() == "ClusterMap21") {
       auto* h2 = dynamic_cast<TH2F*>(mo->getObject());
       h2->Scale(scale);
+      result = Quality::Good;
     }
     if (mo->getName() == "ClusterMap22") {
       auto* h2 = dynamic_cast<TH2F*>(mo->getObject());
       h2->Scale(scale);
+      result = Quality::Good;
     }
   }
   return result;

Modules/MUON/MID/src/DigitsQcCheck.cxx

@@ -62,7 +62,7 @@ void DigitsQcCheck::configure()
 
 Quality DigitsQcCheck::check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap)
 {
-  Quality result = Quality::Null;
+  Quality result = Quality::Good;
   // This info must be available from the beginning
   TH1* meanMultiHits = nullptr;
   for (auto& item : *moMap) {
@@ -169,6 +169,7 @@ Quality DigitsQcCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
           qual.addReason(flag, fmt::format("{} boards empty", nEmptyLB));
         }
         mQualityMap[item.second->getName()] = qual;
+        result = qual;
       } // if mNTFInSeconds > 0.
     }
     if (item.second->getName() == "NbLBEmpty") {
@@ -193,6 +194,7 @@ Quality DigitsQcCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
       }
     }
   }
+
   return result;
 }
 

Modules/MUON/MID/src/TracksQcCheck.cxx

@@ -84,14 +84,15 @@ Quality TracksQcCheck::check(std::map<std::string, std::shared_ptr<MonitorObject
         for (int i = 1; i < h->GetNbinsX(); i++) {
           if ((i == 1) && (h->GetBinContent(i) < mRatio44Threshold)) {
             result = Quality::Bad;
+
             result.addReason(FlagReasonFactory::Unknown(),
-                             "All Ratio44 too high in bin " + std::to_string(i));
+                             "Global Ratio44 too low : bin " + std::to_string(i));
             lineThreshold->SetLineColor(kRed);
             break;
           } else if ((i > 1) && (i < 10) && (h->GetBinContent(i) < mRatio44Threshold)) {
             result = Quality::Medium;
             result.addReason(FlagReasonFactory::Unknown(),
-                             "Ratio44 too high in bin " + std::to_string(i));
+                             "Ratio44 too low in bin " + std::to_string(i));
             lineThreshold->SetLineColor(kOrange);
             break;
           }