Skip to content

Commit fb19f7a

Browse files
lauraserLaura Serksnyte
andauthored
Fix ERROR at the end of short runs, when no trigger is present for Quality Observer (#2065)
Co-authored-by: Laura Serksnyte <laura.serksnyte@cern.ch>
1 parent 92aaaff commit fb19f7a

2 files changed

Lines changed: 12 additions & 4 deletions

File tree

Modules/TPC/src/QualityObserver.cxx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,13 @@ void QualityObserver::update(Trigger t, framework::ServiceRegistryRef services)
106106
generatePanel();
107107
}
108108

109-
void QualityObserver::finalize(Trigger t, framework::ServiceRegistryRef)
109+
void QualityObserver::finalize(Trigger t, framework::ServiceRegistryRef services)
110110
{
111-
generatePanel();
111+
auto& qcdb = services.get<repository::DatabaseInterface>();
112+
getQualities(t, qcdb);
113+
if (mQualities.size() > 0 && mReasons.size() > 0 && mComments.size() > 0) {
114+
generatePanel();
115+
}
112116
}
113117

114118
void QualityObserver::getQualities(const Trigger& t,

Modules/TPC/src/RatioGeneratorTPC.cxx

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,18 @@ void RatioGeneratorTPC::update(Trigger t, framework::ServiceRegistryRef services
6262
generatePlots();
6363
}
6464

65-
void RatioGeneratorTPC::finalize(Trigger t, framework::ServiceRegistryRef)
65+
void RatioGeneratorTPC::finalize(Trigger t, framework::ServiceRegistryRef services)
6666
{
6767
for (const auto& source : mConfig) {
6868
if (mRatios.count(source.nameOutputObject)) {
6969
getObjectsManager()->stopPublishing(source.nameOutputObject);
7070
}
7171
}
72-
generatePlots();
72+
auto& qcdb = services.get<repository::DatabaseInterface>();
73+
generateRatios(t, qcdb);
74+
if (mRatios.size() > 0) {
75+
generatePlots();
76+
}
7377
}
7478

7579
void RatioGeneratorTPC::generateRatios(const Trigger& t,

0 commit comments

Comments
 (0)