[Important] Fix bug with geometry in ITS FHR task (#1705)

* [WIP] [Important] Fix bug with geometry in ITS FHR task

DO NOT MERGE YET - TEST ONGOING

* fixed bug in ITS FHR task and removed unused json param reading

Author: iravasen

Modules/ITS/include/ITS/ITSClusterTask.h

@@ -128,10 +128,7 @@ class ITSClusterTask : public TaskInterface
   int mNRofs = 0;
   int nBCbins = 103;
   long int mTimestamp = -1;
-  std::string mGeomPath = "./";
   TString xLabel;
-  std::string mGeoTimestamp = "1640991600000";
-  int mLocalGeometryFile = 1;
   int mDoPublishDetailedSummary = 0;
 
   const int mNStaves[NLayer] = { 12, 16, 20, 24, 30, 42, 48 };

Modules/ITS/include/ITS/ITSFhrTask.h

@@ -161,9 +161,6 @@ class ITSFhrTask final : public TaskInterface
 
   // Geometry decoder
   o2::its::GeometryTGeo* mGeom;
-  std::string mGeomPath = "./";
-  std::string mGeoTimestamp = "1640991600000";
-  int mLocalGeometryFile = 1;
 };
 } // namespace o2::quality_control_modules::its
 

Modules/ITS/src/ITSClusterTask.cxx

@@ -571,11 +571,8 @@ void ITSClusterTask::createAllHistos()
 
 void ITSClusterTask::getJsonParameters()
 {
-  mLocalGeometryFile = o2::quality_control_modules::common::getFromConfig<int>(mCustomParameters, "isLocalGeometry", mLocalGeometryFile);
-  mGeoTimestamp = o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "geomstamp", mGeoTimestamp);
   mNThreads = o2::quality_control_modules::common::getFromConfig<int>(mCustomParameters, "nThreads", mNThreads);
   nBCbins = o2::quality_control_modules::common::getFromConfig<int>(mCustomParameters, "nBCbins", nBCbins);
-  mGeomPath = o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "geomPath", mGeomPath);
   mDoPublish1DSummary = o2::quality_control_modules::common::getFromConfig<int>(mCustomParameters, "publishSummary1D", mDoPublish1DSummary);
   std::string LayerConfig = o2::quality_control_modules::common::getFromConfig<std::string>(mCustomParameters, "layer", "0000000");
   mDoPublishDetailedSummary = o2::quality_control_modules::common::getFromConfig<int>(mCustomParameters, "publishDetailedSummary", mDoPublishDetailedSummary);

Modules/ITS/src/ITSFhrTask.cxx

@@ -112,10 +112,7 @@ void ITSFhrTask::initialize(o2::framework::InitContext& /*ctx*/)
   mDecoder->setNThreads(mNThreads);
   mDecoder->setUserDataOrigin(header::DataOrigin("DS")); // set user data origin in dpl
   mDecoder->setUserDataDescription(header::DataDescription("RAWDATA0"));
-  mChipsBuffer.resize(mGeom->getNumberOfChips());
-
-  mGeom->fillMatrixCache(o2::math_utils::bit2Mask(o2::math_utils::TransformType::L2G));
-  const math_utils::Point3D<float> loc(0., 0., 0.);
+  mChipsBuffer.resize(24120);
 
   if (mLayer != -1) {
     // define the hitnumber, occupancy, errorcount array
@@ -401,6 +398,7 @@ void ITSFhrTask::monitorData(o2::framework::ProcessingContext& ctx)
 {
   if (ctx.services().get<o2::framework::TimingInfo>().globalRunNumberChanged) {
     mGeom = o2::its::GeometryTGeo::Instance();
+    mGeom->fillMatrixCache(o2::math_utils::bit2Mask(o2::math_utils::TransformType::L2G));
   }
   // set timer
   std::chrono::time_point<std::chrono::high_resolution_clock> start;
@@ -729,9 +727,6 @@ void ITSFhrTask::monitorData(o2::framework::ProcessingContext& ctx)
 
 void ITSFhrTask::getParameters()
 {
-  mLocalGeometryFile = o2::quality_control_modules::common::getFromConfig<int>(mCustomParameters, "isLocalGeometry", mLocalGeometryFile);
-  mGeoTimestamp = o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "geomstamp", mGeoTimestamp);
-  mGeomPath = o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "geomPath", mGeomPath);
   mNThreads = o2::quality_control_modules::common::getFromConfig<int>(mCustomParameters, "decoderThreads", mNThreads);
   mLayer = o2::quality_control_modules::common::getFromConfig<int>(mCustomParameters, "Layer", mLayer);
   mHitCutForCheck = o2::quality_control_modules::common::getFromConfig<int>(mCustomParameters, "HitNumberCut", mHitCutForCheck);