Fix IndexError padding a nested empty table#445
Open
santhreal wants to merge 1 commit into
Open
Conversation
pad_tables reformats each table via reformat_table(), which indexes lines[0] to size columns. A nested table emits two adjacent pad markers with no rows buffered between them, so reformat_table receives an empty list and raises IndexError on valid (e.g. email) HTML. An empty buffer has nothing to pad, so return early.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
pad_tablesenabled, each table is reformatted byreformat_table(), which sizes its columns vialines[0].split("|"). A nested table (e.g.<table><table></table></table>, common in email/layout HTML) emits two adjacent pad markers with no rows buffered between them, soreformat_tablereceives an empty list and raisesIndexError: list index out of range.An empty buffer has no rows to pad, so return early. A single empty
<table></table>was already fine; only the nested case produced the empty inner buffer.Added
test_reformat_table_empty_returns_emptyandtest_pad_tables_nested_empty_table.