feat: auto-tag managed ERDMA ENIs for terway coexistence#28
Open
BSWANG wants to merge 1 commit into
Open
Conversation
All ERDMA ENIs managed by this controller are now automatically tagged with terway.alibabacloud.com/excluded=true (+ instance-id), so that terway can recognize and skip them without any user-side eni_tag_filter configuration. ENIs created by this controller additionally carry the existing creator=alibabacloud-erdma-controller tag (set at CreateNetworkInterface time). Pre-bound or converted ENIs only get the excluded + instance-id tags to avoid misleading ownership claims. Existing nodes get their ENI tags backfilled on the next reconcile after controller upgrade (dedup'd in-memory, at most one TagResources call per ENI per process lifetime). RAM policy now requires ecs:TagResources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
terway.alibabacloud.com/excluded=true(+instance-id), so that terway can recognize and skip them without any user-sideeni_tag_filterconfiguration.creator=alibabacloud-erdma-controllertag (set at CreateNetworkInterface time). Pre-bound or converted ENIs only get the excluded + instance-id tags to avoid misleading ownership claims.ecs:TagResources.Test plan
go build ./internal/controller/...passesgo test ./internal/controller/...passes (existing + newTestEnsureEriTagsEmptyInputIsNoop)