feat: delay ERI attachment until node is ready#29
Open
BSWANG wants to merge 1 commit into
Open
Conversation
BSWANG
force-pushed
the
feature/wait-node-ready
branch
from
830d73e to
2cc4cbd
Compare
Wait for kubelet to report NodeReady before starting ERI selection and attachment. This avoids repeated failures and potential kernel memory allocation issues when internal drivers are not yet initialized. If a node stays NotReady beyond a configurable timeout (default 5min), proceed anyway as a fallback.
BSWANG
force-pushed
the
feature/wait-node-ready
branch
from
2cc4cbd to
bbf03fb
Compare
Lyt99
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitNodeReadyTimeoutSeconds, default 300s) as fallback — if a node stays NotReady beyond this, proceed anywayTest plan
go buildpasses for all modified packagesgo test ./internal/controller/...passes, including newTestIsNodeReadyandTestPredictNodeUpdatecases