Refine k8s event type: change kubernetes event type from Error to Warning#301
Open
yshngg wants to merge 1 commit into
Open
Conversation
yshngg
changed the title
Error to Warning.Error to Warning.
yshngg
changed the title
Error to Warning.Error to Warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
PR类型是什么？
What this PR does / why we need it:
这个PR解决了什么问题:
Kubernetes currently defines only two event types: Warning and Normal (with possible future expansions). To adhere to Kubernetes semantics and reduce cognitive friction, we should align Prometheus metrics by replacing the non-standard Error type with the canonical Warning type.
Ref: https://kubernetes.io/docs/reference/kubernetes-api/cluster-resources/event-v1/
Does this PR introduce a breaking change?:
PR带来的破坏性变更:
NONE
Test/Final result:
测试/最终运行结果: