Skip to content

Commit 0d8a697

Browse files
committed
fix(pr/shared): improve ParseFullReference error message
Signed-off-by: Babak K. Shandiz <babakks@github.com>
1 parent bd0177b commit 0d8a697

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

pkg/cmd/pr/shared/finder.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -349,7 +349,7 @@ func ParseFullReference(s string) (ghrepo.Interface, int, error) {
349349

350350
number, err := strconv.Atoi(m[3])
351351
if err != nil {
352-
return nil, 0, fmt.Errorf("invalid reference: %q", s)
352+
return nil, 0, fmt.Errorf("invalid reference: %q; %w", s, err)
353353
}
354354

355355
owner := m[1]

pkg/cmd/pr/shared/finder_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,11 @@ func TestParseFullReference(t *testing.T) {
160160
arg: "OWNER/#123",
161161
wantErr: `invalid reference: "OWNER/#123"`,
162162
},
163+
{
164+
name: "invalid full form, too large number",
165+
arg: "OWNER/REPO#9999999999999999999",
166+
wantErr: `invalid reference: "OWNER/REPO#9999999999999999999"; strconv.Atoi: parsing "9999999999999999999": value out of range`,
167+
},
163168
}
164169

165170
for _, tt := range tests {

0 commit comments

Comments
 (0)