refactor(pkg/search): rewrite returns in a more verbose way

babakks · babakks · commit 1533d8177c1f · 2025-11-20T16:26:27.000Z
Signed-off-by: Babak K. Shandiz &lt;babakks@github.com&gt;
diff --git a/pkg/search/query.go b/pkg/search/query.go
@@ -148,11 +148,16 @@ func (q Query) AdvancedIssueSearchString() string {
 		keywords = strings.Join(formatKeywords(q.Keywords), " ")
 	}
 
+	if qualifiers == "" && keywords == "" {
+		return ""
+	}
+
 	if qualifiers != "" && keywords != "" {
 		// We should surround keywords with brackets to avoid leaking of any operators, especially "OR"s.
 		return fmt.Sprintf("( %s ) %s", keywords, qualifiers)
 	}
-	if qualifiers == "" {
+
+	if keywords != "" {
 		return keywords
 	}
 	return qualifiers

Original file line number	Diff line number	Diff line change
`@@ -148,11 +148,16 @@ func (q Query) AdvancedIssueSearchString() string {`
`148`	`148`	`keywords = strings.Join(formatKeywords(q.Keywords), " ")`
`149`	`149`	`}`
`150`	`150`
	`151`	`+ if qualifiers == "" && keywords == "" {`
	`152`	`+ return ""`
	`153`	`+ }`
	`154`	`+`
`151`	`155`	`if qualifiers != "" && keywords != "" {`
`152`	`156`	`// We should surround keywords with brackets to avoid leaking of any operators, especially "OR"s.`
`153`	`157`	`return fmt.Sprintf("( %s ) %s", keywords, qualifiers)`
`154`	`158`	`}`
`155`		`- if qualifiers == "" {`
	`159`	`+`
	`160`	`+ if keywords != "" {`
`156`	`161`	`return keywords`
`157`	`162`	`}`
`158`	`163`	`return qualifiers`