Skip to content

Commit 3e43a98

Browse files
committed
refactor(agent-task view): merge empty println calls with next
Signed-off-by: Babak K. Shandiz <babakks@github.com>
1 parent 3091c21 commit 3e43a98

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

pkg/cmd/agent-task/view/view.go

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -337,8 +337,7 @@ func printSession(opts *ViewOptions, session *capi.Session) {
337337
if message == "" {
338338
message = "An error occurred"
339339
}
340-
fmt.Fprintln(opts.IO.Out, "")
341-
fmt.Fprintf(opts.IO.Out, "%s %s\n", cs.FailureIconWithColor(cs.Red), message)
340+
fmt.Fprintf(opts.IO.Out, "\n%s %s\n", cs.FailureIconWithColor(cs.Red), message)
342341

343342
if workflowRunURL != "" {
344343
// We don't need to prefix the link with any text (e.g. "checkout the logs here")
@@ -348,16 +347,13 @@ func printSession(opts *ViewOptions, session *capi.Session) {
348347
}
349348

350349
if !opts.Log {
351-
fmt.Fprintln(opts.IO.Out, "")
352-
fmt.Fprintf(opts.IO.Out, "For detailed session logs, try:\ngh agent-task view '%s' --log\n", session.ID)
350+
fmt.Fprintf(opts.IO.Out, "\nFor detailed session logs, try:\ngh agent-task view '%s' --log\n", session.ID)
353351
} else if !opts.Follow {
354-
fmt.Fprintln(opts.IO.Out, "")
355-
fmt.Fprintf(opts.IO.Out, "To follow session logs, try:\ngh agent-task view '%s' --log --follow\n", session.ID)
352+
fmt.Fprintf(opts.IO.Out, "\nTo follow session logs, try:\ngh agent-task view '%s' --log --follow\n", session.ID)
356353
}
357354

358355
if session.PullRequest != nil {
359-
fmt.Fprintln(opts.IO.Out, "")
360-
fmt.Fprintln(opts.IO.Out, cs.Muted("View this session on GitHub:"))
356+
fmt.Fprintln(opts.IO.Out, cs.Muted("\nView this session on GitHub:"))
361357
fmt.Fprintln(opts.IO.Out, cs.Muted(fmt.Sprintf("%s/agent-sessions/%s", session.PullRequest.URL, url.PathEscape(session.ID))))
362358
}
363359
}

0 commit comments

Comments
 (0)