Add TODO requestReviewsByLoginCleanup on GHES ID-based reviewer path

BagToad · Copilot · BagToad · commit 49f1bd88004d · 2026-03-05T10:58:23.000-07:00
Mark the GHES ID-resolution branch in AddMetadataToIssueParams
for cleanup once GHES supports requestReviewsByLogin.

Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/pkg/cmd/pr/shared/params.go b/pkg/cmd/pr/shared/params.go
@@ -130,8 +130,10 @@ func AddMetadataToIssueParams(client *api.Client, baseRepo ghrepo.Interface, par
 		}
 	}
 
+	// TODO requestReviewsByLoginCleanup
 	// When ActorReviewers is true (github.com), pass logins directly for use with
-	// RequestReviewsByLogin mutation. Otherwise, resolve to IDs for GHES compatibility.
+	// RequestReviewsByLogin mutation. The ID-based else branch can be removed once
+	// GHES supports requestReviewsByLogin.
 	if tb.ActorReviewers {
 		params["userReviewerLogins"] = userReviewers
 		if len(botReviewers) > 0 {

Original file line number	Diff line number	Diff line change
`@@ -130,8 +130,10 @@ func AddMetadataToIssueParams(client *api.Client, baseRepo ghrepo.Interface, par`
`130`	`130`	`}`
`131`	`131`	`}`
`132`	`132`
	`133`	`+ // TODO requestReviewsByLoginCleanup`
`133`	`134`	`// When ActorReviewers is true (github.com), pass logins directly for use with`
`134`		`- // RequestReviewsByLogin mutation. Otherwise, resolve to IDs for GHES compatibility.`
	`135`	`+ // RequestReviewsByLogin mutation. The ID-based else branch can be removed once`
	`136`	`+ // GHES supports requestReviewsByLogin.`
`135`	`137`	`if tb.ActorReviewers {`
`136`	`138`	`params["userReviewerLogins"] = userReviewers`
`137`	`139`	`if len(botReviewers) > 0 {`