Merge pull request cli#11805 from juejinyuxitu/FieldsFuncSeq

babakks · web-flow · commit 52ba8366057b · 2025-09-30T11:18:57.000+01:00
refactor: use strings.FieldsFuncSeq to reduce memory allocations
diff --git a/pkg/cmd/gist/list/list.go b/pkg/cmd/gist/list/list.go
@@ -250,7 +250,7 @@ func printContent(io *iostreams.IOStreams, gists []shared.Gist, filter *regexp.R
 			}
 
 			if file.Content != "" {
-				for _, line := range strings.FieldsFunc(file.Content, split) {
+				for line := range strings.FieldsFuncSeq(file.Content, split) {
 					if filter.MatchString(line) {
 						if line, err = highlightMatch(line, filter, &matched, normal, cs.Highlight); err != nil {
 							return err

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ func printContent(io iostreams.IOStreams, gists []shared.Gist, filter regexp.R`
`250`	`250`	`}`
`251`	`251`
`252`	`252`	`if file.Content != "" {`
`253`		`- for _, line := range strings.FieldsFunc(file.Content, split) {`
	`253`	`+ for line := range strings.FieldsFuncSeq(file.Content, split) {`
`254`	`254`	`if filter.MatchString(line) {`
`255`	`255`	`if line, err = highlightMatch(line, filter, &matched, normal, cs.Highlight); err != nil {`
`256`	`256`	`return err`