Skip to content

Commit 806ae03

Browse files
authored
Merge pull request cli#11261 from cli/attester/tenancy-aware-for-san
2 parents 08303d9 + d068696 commit 806ae03

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

pkg/cmd/release/shared/attestation.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ func (v *AttestationVerifier) VerifyAttestation(art *artifact.DigestedArtifact,
4646
return nil, err
4747
}
4848

49-
policy := buildVerificationPolicy(*art)
49+
policy := buildVerificationPolicy(*art, td)
5050
sigstoreVerified, err := verifier.Verify([]*api.Attestation{att}, policy)
5151
if err != nil {
5252
return nil, err
@@ -99,9 +99,13 @@ func FilterAttestationsByFileDigest(attestations []*api.Attestation, fileDigest
9999
}
100100

101101
// buildVerificationPolicy constructs a verification policy for GitHub releases
102-
func buildVerificationPolicy(a artifact.DigestedArtifact) verify.PolicyBuilder {
102+
func buildVerificationPolicy(a artifact.DigestedArtifact, trustDomain string) verify.PolicyBuilder {
103+
// If no trust domain is specified, default to "dotcom"
104+
if trustDomain == "" {
105+
trustDomain = "dotcom"
106+
}
103107
// SAN must match the GitHub releases domain. No issuer extension (match anything)
104-
sanMatcher, _ := verify.NewSANMatcher("", "^https://.*\\.releases\\.github\\.com$")
108+
sanMatcher, _ := verify.NewSANMatcher("", fmt.Sprintf("^https://%s\\.releases\\.github\\.com$", trustDomain))
105109
issuerMatcher, _ := verify.NewIssuerMatcher("", ".*")
106110
certId, _ := verify.NewCertificateIdentity(sanMatcher, issuerMatcher, certificate.Extensions{})
107111

0 commit comments

Comments
 (0)