Skip to content

Commit 87b310a

Browse files
committed
fix(agent-task view): display completed sessions as "Ready for review"
Signed-off-by: Babak K. Shandiz <babakks@github.com>
1 parent 897c2b1 commit 87b310a

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

pkg/cmd/agent-task/shared/display.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func SessionStateString(state string) string {
3232
case "in_progress":
3333
return "In Progress"
3434
case "completed":
35-
return "Completed"
35+
return "Ready for review"
3636
case "failed":
3737
return "Failed"
3838
case "idle":

pkg/cmd/agent-task/view/view_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ func Test_viewRun(t *testing.T) {
230230
}
231231
},
232232
wantOut: heredoc.Doc(`
233-
Completed • fix something • OWNER/REPO#101
233+
Ready for review • fix something • OWNER/REPO#101
234234
Started on behalf of octocat about 6 hours ago
235235
236236
For detailed session logs, try:
@@ -267,7 +267,7 @@ func Test_viewRun(t *testing.T) {
267267
}
268268
},
269269
wantOut: heredoc.Doc(`
270-
Completed • fix something • OWNER/REPO#101
270+
Ready for review • fix something • OWNER/REPO#101
271271
Started about 6 hours ago
272272
273273
For detailed session logs, try:
@@ -299,7 +299,7 @@ func Test_viewRun(t *testing.T) {
299299
}
300300
},
301301
wantOut: heredoc.Doc(`
302-
Completed
302+
Ready for review
303303
Started on behalf of octocat about 6 hours ago
304304
305305
For detailed session logs, try:
@@ -325,7 +325,7 @@ func Test_viewRun(t *testing.T) {
325325
}
326326
},
327327
wantOut: heredoc.Doc(`
328-
Completed
328+
Ready for review
329329
Started about 6 hours ago
330330
331331
For detailed session logs, try:
@@ -507,7 +507,7 @@ func Test_viewRun(t *testing.T) {
507507
}
508508
},
509509
wantOut: heredoc.Doc(`
510-
Completed • fix something • OWNER/REPO#101
510+
Ready for review • fix something • OWNER/REPO#101
511511
Started on behalf of octocat about 6 hours ago
512512
513513
For detailed session logs, try:
@@ -587,7 +587,7 @@ func Test_viewRun(t *testing.T) {
587587
)
588588
},
589589
wantOut: heredoc.Doc(`
590-
Completed • fix something • OWNER/REPO#101
590+
Ready for review • fix something • OWNER/REPO#101
591591
Started on behalf of octocat about 6 hours ago
592592
593593
For detailed session logs, try:
@@ -669,7 +669,7 @@ func Test_viewRun(t *testing.T) {
669669
)
670670
},
671671
wantOut: heredoc.Doc(`
672-
Completed • fix something • OWNER/REPO#101
672+
Ready for review • fix something • OWNER/REPO#101
673673
Started on behalf of octocat about 6 hours ago
674674
675675
For detailed session logs, try:
@@ -890,7 +890,7 @@ func Test_viewRun(t *testing.T) {
890890
}
891891
},
892892
wantOut: heredoc.Doc(`
893-
Completed
893+
Ready for review
894894
Started on behalf of octocat about 6 hours ago
895895
896896
To follow session logs, try:
@@ -947,7 +947,7 @@ func Test_viewRun(t *testing.T) {
947947
}
948948
},
949949
wantOut: heredoc.Doc(`
950-
Completed
950+
Ready for review
951951
Started on behalf of octocat about 6 hours ago
952952
953953
(rendered:) <raw-logs-one>

0 commit comments

Comments
 (0)