Skip to content

Commit 9b4a989

Browse files
Merge pull request cli#13033 from Lslightly/13001-fix-err-data-race-and-heap-alloc
define err in go func instead of use err defined in outer scope
2 parents d81c9bb + e53e360 commit 9b4a989

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

internal/codespaces/portforwarder/port_forwarder.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -276,7 +276,7 @@ func (fwd *CodespacesPortForwarder) UpdatePortVisibility(ctx context.Context, re
276276
done := make(chan error)
277277
go func() {
278278
// Connect to the tunnel
279-
err = fwd.connection.Connect(ctx)
279+
err := fwd.connection.Connect(ctx)
280280
if err != nil {
281281
done <- fmt.Errorf("connect failed: %v", err)
282282
return

0 commit comments

Comments
 (0)