test(issue list): cover additional PR search qualifier variants

Author: Louis Shawn

pkg/cmd/issue/list/http_test.go

@@ -216,20 +216,54 @@ func TestSearchIssuesAndAdvancedSearch(t *testing.T) {
 }
 
 func TestSearchIssues_rejectsPullRequestQualifiers(t *testing.T) {
-	reg := &httpmock.Registry{}
-	defer reg.Verify(t)
+	tests := []struct {
+		name   string
+		search string
+	}{
+		{
+			name:   "is:pr",
+			search: "is:pr",
+		},
+		{
+			name:   "type:pr",
+			search: "type:pr",
+		},
+		{
+			name:   "type:pull-request",
+			search: "type:pull-request",
+		},
+		{
+			name:   "type:pullrequest",
+			search: "type:pullrequest",
+		},
+		{
+			name:   "case-insensitive is:PR",
+			search: "is:PR",
+		},
+		{
+			name:   "case-insensitive TYPE:Pull-Request",
+			search: "TYPE:Pull-Request",
+		},
+	}
 
-	httpClient := &http.Client{Transport: reg}
-	client := api.NewClientFromHTTP(httpClient)
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			reg := &httpmock.Registry{}
+			defer reg.Verify(t)
 
-	_, err := searchIssues(
-		client,
-		fd.AdvancedIssueSearchSupportedAsOnlyBackend(),
-		ghrepo.New("OWNER", "REPO"),
-		prShared.FilterOptions{Search: "is:pr"},
-		30,
-	)
+			httpClient := &http.Client{Transport: reg}
+			client := api.NewClientFromHTTP(httpClient)
 
-	assert.EqualError(t, err, "cannot use pull request search qualifiers with `gh issue list`; use `gh pr list` instead")
-	assert.Len(t, reg.Requests, 0)
+			_, err := searchIssues(
+				client,
+				fd.AdvancedIssueSearchSupportedAsOnlyBackend(),
+				ghrepo.New("OWNER", "REPO"),
+				prShared.FilterOptions{Search: tt.search},
+				30,
+			)
+
+			assert.EqualError(t, err, "cannot use pull request search qualifiers with `gh issue list`; use `gh pr list` instead")
+			assert.Len(t, reg.Requests, 0)
+		})
+	}
 }