udpate the test

Author: ejahnGithub

pkg/cmd/release/shared/fetch_test.go

@@ -5,6 +5,8 @@ import (
 	"net/http"
 	"testing"
 
+	"github.com/cli/go-gh/v2/pkg/api"
+
 	"github.com/cli/cli/v2/internal/ghrepo"
 	"github.com/cli/cli/v2/pkg/httpmock"
 	"github.com/stretchr/testify/assert"
@@ -13,61 +15,41 @@ import (
 
 func TestFetchRefSHA(t *testing.T) {
 	tests := []struct {
-		name           string
-		tagName        string
-		responseStatus int
-		responseBody   string
-		expectedSHA    string
-		errorMessage   string
+		name            string
+		tagName         string
+		responseStatus  int
+		responseBody    string
+		responseMessage string
+		expectedSHA     string
+		errorMessage    string
 	}{
 		{
-			name:           "full semver tag",
+			name:           "match (200)",
 			tagName:        "v1.2.3",
 			responseStatus: 200,
 			responseBody:   `{"object": {"sha": "1234567890abcdef1234567890abcdef12345678"}}`,
 			expectedSHA:    "1234567890abcdef1234567890abcdef12345678",
 		},
 		{
-			name:           "partial semver - major only",
-			tagName:        "v1",
-			responseStatus: 200,
-			responseBody:   `{"object": {"sha": "abcdef1234567890abcdef1234567890abcdef12"}}`,
-			expectedSHA:    "abcdef1234567890abcdef1234567890abcdef12",
-		},
-		{
-			name:           "partial semver - major.minor",
-			tagName:        "v1.2",
-			responseStatus: 200,
-			responseBody:   `{"object": {"sha": "fedcba0987654321fedcba0987654321fedcba09"}}`,
-			expectedSHA:    "fedcba0987654321fedcba0987654321fedcba09",
-		},
-		{
-			name:           "prerelease tag",
-			tagName:        "v1.2.3-alpha.1",
-			responseStatus: 200,
-			responseBody:   `{"object": {"sha": "9876543210fedcba9876543210fedcba98765432"}}`,
-			expectedSHA:    "9876543210fedcba9876543210fedcba98765432",
-		},
-		{
-			name:           "tag not found",
-			tagName:        "v99.99.99",
-			responseStatus: 404,
-			responseBody:   ``,
-			errorMessage:   "release not found",
+			name:            "non-match (404)",
+			tagName:         "v1.2.3",
+			responseStatus:  404,
+			responseMessage: `Not found`,
+			errorMessage:    "release not found",
 		},
 		{
-			name:           "empty response body with 200 status",
-			tagName:        "v1.0.0",
-			responseStatus: 200,
-			responseBody:   `{}`,
-			errorMessage:   "release not found",
+			name:            "server error (500)",
+			tagName:         "v1.2.3",
+			responseStatus:  500,
+			responseMessage: `arbitrary error"`,
+			errorMessage:    "HTTP 500: arbitrary error\" (https://api.github.com/repos/owner/repo/git/ref/tags/v1.2.3)",
 		},
 		{
-			name:           "malformed JSON response",
-			tagName:        "v1.0.0",
+			name:           "malformed JSON with 200",
+			tagName:        "v1.2.3",
 			responseStatus: 200,
 			responseBody:   `{"object": {"sha":`,
-			errorMessage:   "failed to parse Git ref response: unexpected EOF",
+			errorMessage:   "failed to parse ref response: unexpected EOF",
 		},
 	}
 
@@ -80,10 +62,19 @@ func TestFetchRefSHA(t *testing.T) {
 			require.NoError(t, err)
 
 			path := "repos/owner/repo/git/ref/tags/" + tt.tagName
-			if tt.responseStatus == 404 {
-				fakeHTTP.Register(httpmock.REST("GET", path), httpmock.StatusStringResponse(404, "Not Found"))
+			if tt.responseStatus == 404 || tt.responseStatus == 500 {
+				fakeHTTP.Register(
+					httpmock.REST("GET", path),
+					httpmock.JSONErrorResponse(tt.responseStatus, api.HTTPError{
+						StatusCode: tt.responseStatus,
+						Message:    tt.responseMessage,
+					}),
+				)
 			} else {
-				fakeHTTP.Register(httpmock.REST("GET", path), httpmock.StringResponse(tt.responseBody))
+				fakeHTTP.Register(
+					httpmock.REST("GET", path),
+					httpmock.StatusStringResponse(tt.responseStatus, tt.responseBody),
+				)
 			}
 
 			httpClient := &http.Client{Transport: fakeHTTP}
@@ -92,8 +83,8 @@ func TestFetchRefSHA(t *testing.T) {
 			sha, err := FetchRefSHA(ctx, httpClient, repo, tt.tagName)
 
 			if tt.errorMessage != "" {
-				require.Error(t, err)
-				assert.EqualError(t, err, tt.errorMessage)
+				assert.Contains(t, err.Error(), tt.errorMessage)
+				assert.Empty(t, sha)
 			} else {
 				require.NoError(t, err)
 				assert.Equal(t, tt.expectedSHA, sha)