Merge pull request cli#11879 from cli/kw/fix-progress-indicator-for-create-follow

babakks · web-flow · commit c8152ed44efd · 2025-10-08T10:55:53.000+02:00
`gh agent-task create`: Fix `--follow` not killing the progress indicator
diff --git a/pkg/cmd/agent-task/create/create.go b/pkg/cmd/agent-task/create/create.go
@@ -166,6 +166,8 @@ func createRun(opts *CreateOptions) error {
 	}
 
 	if opts.Follow {
+		opts.IO.StopProgressIndicator()
+		fmt.Fprintf(opts.IO.Out, "Displaying session logs for job %s. Press Ctrl+C to stop.\n", job.ID)
 		return followLogs(opts, client, job.SessionID)
 	}
 
diff --git a/pkg/cmd/agent-task/create/create_test.go b/pkg/cmd/agent-task/create/create_test.go
@@ -488,6 +488,7 @@ func Test_createRun(t *testing.T) {
 				}
 			},
 			wantStdout: heredoc.Doc(`
+				Displaying session logs for job job123. Press Ctrl+C to stop.
 				(rendered:) <raw-logs-one>
 				(rendered:) <raw-logs-two>
 			`),

Original file line number	Diff line number	Diff line change
`@@ -166,6 +166,8 @@ func createRun(opts *CreateOptions) error {`
`166`	`166`	`}`
`167`	`167`
`168`	`168`	`if opts.Follow {`
	`169`	`+ opts.IO.StopProgressIndicator()`
	`170`	`+ fmt.Fprintf(opts.IO.Out, "Displaying session logs for job %s. Press Ctrl+C to stop.\n", job.ID)`
`169`	`171`	`return followLogs(opts, client, job.SessionID)`
`170`	`172`	`}`
`171`	`173`
Original file line number	Diff line number	Diff line change
`@@ -488,6 +488,7 @@ func Test_createRun(t *testing.T) {`
`488`	`488`	`}`
`489`	`489`	`},`
`490`	`490`	wantStdout: heredoc.Doc(`
	`491`	`+ Displaying session logs for job job123. Press Ctrl+C to stop.`
`491`	`492`	`(rendered:) <raw-logs-one>`
`492`	`493`	`(rendered:) <raw-logs-two>`
`493`	`494`	`),