Merge pull request cli#12623 from LouisLau-art/fix/issue-list-pr-search-qualifier

fix(issue list): reject pull request-only search qualifiers

Author: BagToad

pkg/cmd/issue/list/http.go

@@ -2,13 +2,16 @@ package list
 
 import (
 	"fmt"
+	"regexp"
 
 	"github.com/cli/cli/v2/api"
 	fd "github.com/cli/cli/v2/internal/featuredetection"
 	"github.com/cli/cli/v2/internal/ghrepo"
 	prShared "github.com/cli/cli/v2/pkg/cmd/pr/shared"
 )
 
+var pullRequestSearchQualifierRE = regexp.MustCompile(`(?i)\b(?:is|type):(?:pr|pull-?request)\b`)
+
 func listIssues(client *api.Client, repo ghrepo.Interface, filters prShared.FilterOptions, limit int) (*api.IssuesAndTotalCount, error) {
 	var states []string
 	switch filters.State {
@@ -114,6 +117,10 @@ loop:
 }
 
 func searchIssues(client *api.Client, detector fd.Detector, repo ghrepo.Interface, filters prShared.FilterOptions, limit int) (*api.IssuesAndTotalCount, error) {
+	if pullRequestSearchQualifierRE.MatchString(filters.Search) {
+		return nil, fmt.Errorf("cannot use pull request search qualifiers with `gh issue list`; use `gh pr list` instead")
+	}
+
 	// TODO advancedIssueSearchCleanup
 	// We won't need feature detection when GHES 3.17 support ends, since
 	// the advanced issue search is the only available search backend for

pkg/cmd/issue/list/http_test.go

@@ -214,3 +214,56 @@ func TestSearchIssuesAndAdvancedSearch(t *testing.T) {
 		})
 	}
 }
+
+func TestSearchIssues_rejectsPullRequestQualifiers(t *testing.T) {
+	tests := []struct {
+		name   string
+		search string
+	}{
+		{
+			name:   "is:pr",
+			search: "is:pr",
+		},
+		{
+			name:   "type:pr",
+			search: "type:pr",
+		},
+		{
+			name:   "type:pull-request",
+			search: "type:pull-request",
+		},
+		{
+			name:   "type:pullrequest",
+			search: "type:pullrequest",
+		},
+		{
+			name:   "case-insensitive is:PR",
+			search: "is:PR",
+		},
+		{
+			name:   "case-insensitive TYPE:Pull-Request",
+			search: "TYPE:Pull-Request",
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			reg := &httpmock.Registry{}
+			defer reg.Verify(t)
+
+			httpClient := &http.Client{Transport: reg}
+			client := api.NewClientFromHTTP(httpClient)
+
+			_, err := searchIssues(
+				client,
+				fd.AdvancedIssueSearchSupportedAsOnlyBackend(),
+				ghrepo.New("OWNER", "REPO"),
+				prShared.FilterOptions{Search: tt.search},
+				30,
+			)
+
+			assert.EqualError(t, err, "cannot use pull request search qualifiers with `gh issue list`; use `gh pr list` instead")
+			assert.Len(t, reg.Requests, 0)
+		})
+	}
+}