Add support for replaying data by t-b · Pull Request #2712 · AllenInstitute/MIES

t-b · 2026-05-22T19:46:41Z

Current limitations:

Works only with 1HS
No documentation, tests

Steps:

Load Experiment and or acquire data
Define in the builtin procedure window #define REPLAY_DATA
RD_PrepareMIES()
RD_ReplayData("ITC18USB_DEV_0", 0) // 0 is the sweepNo
RD_CompareSCI("ITC18USB_DEV_0", 0, 0) // sweepNo, HS

ToDos:

Instead of overriding the async QC value we should read the read out AD value (Async AD X [XXX]) from the LBN and return that in ASD_ReadChannel
~~Add flag to not override ITI so that it is more accurate~~
Add LBN entry if the data was replayed or not, ignore that in CompareLabnotebook
Finalize ACD_InitDAQSettingsFromString/ACD_AcquireData and port existing tests to new config strings
Add menu option under advanced to enable replay
Make the device argument optional and use the one which was used if it is only one.
Tests
Investigate recent replay errors from PSQ_DA_Scale Adaptive enhancements #2680

Open issues:

Gad2-IRES-Cre;Ai14-863395.03.06.01_replay.pxp

Clamp Mode is different from Operating Mode but both should be the same?? (moved to Fix invalid Clamp Mode labnotebook entry when replaying data #2735)

  •RD_ReplayData("ITC18USB_Dev_0", 5)
  ****************************************************************************************
  Enabling replay data logic. All future data will be replayed and *not* freshly acquired.
  ****************************************************************************************
  •RD_CompareSCI("ITC18USB_Dev_0", 5, 0)
  *** Evaluating sweep and LBN data ***
  *** Sweep: 5 ***
  AcquisitionState: 0;0;0;0;0;0;0;0;0 (orig) vs 5;5;5;5;5;5;5;5;5 (replay)
  TP Baseline Vm: -73.5176 (orig) vs (empty) (replay)
  TP Baseline pA: 6.81421 (orig) vs (empty) (replay)
  TP Peak Resistance: 2.96281 (orig) vs (empty) (replay)
  TP Steady State Resistance: 68.3608 (orig) vs (empty) (replay)
  Slow compensation time: 7.74194e-05 (orig) vs 1e-05 (replay)
  Clamp Mode: 1 (orig) vs 0 (replay)
  TP Baseline Fraction: 0.4714 (orig) vs 0.45 (replay)
  TP Amplitude IC: -57.34 (orig) vs 50 (replay)
  TP Auto QC: 1 (orig) vs (empty) (replay)
  TP Cycle ID: 1.34712e+06 (orig) vs (empty) (replay)
  V-Clamp Holding Enable: 1 (orig) vs 0 (replay)
  V-Clamp Holding Level: -69.9835 (orig) vs -0.000253133 (replay)
  Whole Cell Comp Cap: 1.00004 (orig) vs 1 (replay)
  Whole Cell Comp Resist: 0.999858 (orig) vs 1.00037 (replay)
  Pipette Offset: 76.816 (orig) vs -13.001 (replay)
  Async 2 Gain: 0.01 (orig) vs 1 (replay)
  Async 3 Gain: 0.01 (orig) vs 1 (replay)
  The analysis function procedure window can not be opened when the testpulse is running.

Close #1123

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated 6 comments.

…as maximum current

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

A common problem with post-mortem debugging of analysis functions is that decisions of it are very hard to understand retroactively. The replay data feature allows to use already acquired data as source and runs it through the same DAQ setup again as if one would be witnessing the original DAQ session. As this is a potentially dangerous feature regarding data integrity we hide it beind a compilation flag.

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.

t-b self-assigned this May 22, 2026

Copilot AI review requested due to automatic review settings May 22, 2026 19:46

Copilot started reviewing on behalf of t-b May 22, 2026 19:46 View session

This comment was marked as outdated.

Sign in to view

Copilot AI review requested due to automatic review settings May 29, 2026 13:17

t-b force-pushed the feature/2712-replay-data-support branch from 3ac64b0 to ff700f7 Compare May 29, 2026 13:17

Copilot started reviewing on behalf of t-b May 29, 2026 13:17 View session

This comment was marked as outdated.

Sign in to view

t-b force-pushed the feature/2712-replay-data-support branch from ff700f7 to 8efb3ab Compare May 29, 2026 20:24

This comment was marked as outdated.

Sign in to view

Copilot AI review requested due to automatic review settings May 29, 2026 21:57

t-b force-pushed the feature/2712-replay-data-support branch from 8efb3ab to 0dcf361 Compare May 29, 2026 21:57

Copilot started reviewing on behalf of t-b May 29, 2026 21:57 View session

This comment was marked as outdated.

Sign in to view

t-b mentioned this pull request Jun 1, 2026

PSQ_DA_Scale Adaptive enhancements #2680

Draft

14 tasks

t-b force-pushed the feature/2712-replay-data-support branch from 0dcf361 to 37e2dd2 Compare June 2, 2026 12:56

t-b mentioned this pull request Jun 2, 2026

ACD_AcquireData: Enhance it #2722

Merged

Copilot AI review requested due to automatic review settings June 3, 2026 11:56

t-b force-pushed the feature/2712-replay-data-support branch from 37e2dd2 to 91de91e Compare June 3, 2026 11:56

Copilot started reviewing on behalf of t-b June 3, 2026 11:56 View session

Copilot AI reviewed Jun 3, 2026

View reviewed changes

Comment thread Packages/MIES/MIES_AsynchronousData.ipf

Comment thread Packages/MIES/MIES_SweepSaving.ipf Outdated

Copilot AI review requested due to automatic review settings July 6, 2026 17:06

t-b force-pushed the feature/2712-replay-data-support branch from 145599c to 4e94a26 Compare July 6, 2026 17:06

Copilot started reviewing on behalf of t-b July 6, 2026 17:07 View session

Copilot AI reviewed Jul 6, 2026

View reviewed changes

t-b mentioned this pull request Jul 6, 2026

Fix invalid Clamp Mode labnotebook entry when replaying data #2735

Open

t-b force-pushed the feature/2712-replay-data-support branch from 4e94a26 to 7044d89 Compare July 6, 2026 20:29

ACD_InitDAQSettingsFromString/ACD_AcquireData: Add support for Autobi…

46c6e29

…as maximum current

Copilot AI review requested due to automatic review settings July 7, 2026 10:35

t-b force-pushed the feature/2712-replay-data-support branch from 7044d89 to bc2c244 Compare July 7, 2026 10:35

Copilot started reviewing on behalf of t-b July 7, 2026 10:35 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

Comment thread Packages/MIES/MIES_Replay.ipf

Comment thread Packages/MIES/MIES_Replay.ipf

t-b added 3 commits July 7, 2026 13:48

DC_PrepareLBNEntries: Add labnotebook entry for tracking replayed data

c698e9d

UTF_Replay.ipf: Add tests for replay data feature

a0f51f3

t-b force-pushed the feature/2712-replay-data-support branch from bc2c244 to a0f51f3 Compare July 7, 2026 11:48

t-b requested a review from Copilot July 7, 2026 22:04

Copilot started reviewing on behalf of t-b July 7, 2026 22:05 View session

Copilot AI reviewed Jul 7, 2026

View reviewed changes

Comment thread Packages/MIES/MIES_DAEphys.ipf

Comment thread Packages/MIES/MIES_DAEphys.ipf

Comment thread Packages/MIES/MIES_Replay.ipf

This comment was marked as off-topic.

Sign in to view

t-b assigned timjarsky and unassigned t-b Jul 7, 2026

t-b marked this pull request as ready for review July 7, 2026 22:36

t-b requested review from MichaelHuth and timjarsky as code owners July 7, 2026 22:36

t-b enabled auto-merge July 7, 2026 22:36

timjarsky approved these changes Jul 8, 2026

View reviewed changes

t-b disabled auto-merge July 8, 2026 17:18

t-b merged commit 2b95f25 into main Jul 8, 2026
23 checks passed

t-b deleted the feature/2712-replay-data-support branch July 8, 2026 17:19

Uh oh!

Conversation

t-b commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as off-topic.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

t-b commented May 22, 2026 •

edited

Loading