Add deterministic reversals curriculum#545
Merged
Merged
Conversation
Use MarkovEnvironment (renamed from EnvironmentStatistics) after PR #547
bruno-f-cruz
force-pushed
the
feat-add-deterministic-reversal-curriculum
branch
from
aaa042d to
f544db3
Compare
bruno-f-cruz
force-pushed
the
feat-add-deterministic-reversal-curriculum
branch
from
431afca to
feebca6
Compare
bruno-f-cruz
changed the title
Member
|
@tiffanyona can you confirm you get identical results after the changes I made? |
Collaborator
Author
|
I will check it in a bit |
bruno-f-cruz
requested changes
May 21, 2026
| rule=task_logic.RewardFunctionRule.ON_REWARD, | ||
| ) | ||
| reset_function = task_logic.OnThisPatchEntryRewardFunction( | ||
| probability=task_logic.SetValueFunction(value=task_logic.scalar_value(1)), |
Member
There was a problem hiding this comment.
Do you really need this? Since the rule is on_choice, i think this is redundant
| else: | ||
| reward_available = 100 | ||
| reset_function = task_logic.OnThisPatchEntryRewardFunction( | ||
| probability=task_logic.SetValueFunction(value=task_logic.scalar_value(1)), |
Collaborator
Author
There was a problem hiding this comment.
I never tried without it so not sure of the behavior.
Member
There was a problem hiding this comment.
Ok I will leave it for now since it helps understand the logic anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curriculum for deterministic reversals