-
Notifications
You must be signed in to change notification settings - Fork 21
Expand file tree
/
Copy pathtest_processing.py
More file actions
534 lines (463 loc) · 19.5 KB
/
Copy pathtest_processing.py
File metadata and controls
534 lines (463 loc) · 19.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
"""test processing"""
import unittest
from datetime import datetime
import pydantic
from aind_data_schema_models.system_architecture import CPUArchitecture, OperatingSystem
from aind_data_schema_models.units import MemoryUnit
from aind_data_schema.components.identifiers import Code, DataAsset
from aind_data_schema.components.wrappers import AssetPath
from aind_data_schema.core.processing import (
DataProcess,
Processing,
ProcessName,
ProcessStage,
ResourceTimestamped,
ResourceUsage,
)
t = datetime.fromisoformat("2024-09-13T14:00:00")
code = Code(
name="Example pipeline",
input_data=[
DataAsset(url="s3 path to inputs"),
],
url="https://url/for/pipeline",
version="0.1.1",
)
class ProcessingTest(unittest.TestCase):
"""tests for processing schema"""
def test_constructors(self):
"""test creation"""
with self.assertRaises(pydantic.ValidationError):
Processing()
# Create a valid Processing object
p = Processing.create_with_sequential_process_graph(
data_processes=[
DataProcess(
experimenters=["Dr. Dan"],
process_type=ProcessName.ANALYSIS,
stage=ProcessStage.ANALYSIS,
code=code,
output_path="./path/to/outputs",
start_date_time=t,
end_date_time=t,
),
]
)
self.assertIsNotNone(p)
self.assertEqual(p.data_processes[0].name, ProcessName.ANALYSIS)
with self.assertRaises(pydantic.ValidationError) as e:
DataProcess(process_type=ProcessName.OTHER, notes="")
self.assertIn("stage", repr(e.exception))
self.assertIn("code", repr(e.exception))
self.assertIn("start_date_time", repr(e.exception))
self.assertIn("notes", repr(e.exception))
def test_resource_usage(self):
"""Test the ResourceUsage class"""
resources = ResourceUsage(
os=OperatingSystem.MACOS_SONOMA,
architecture=CPUArchitecture.X86_64,
cpu_usage=[ResourceTimestamped(timestamp=datetime.fromisoformat("2024-09-13"), usage=0.5)],
)
self.assertIsNotNone(resources)
with self.assertRaises(pydantic.ValidationError):
ResourceUsage()
def test_resource_usage_unit_validators(self):
"""Test that unit validators work"""
# Check ram
with self.assertRaises(ValueError) as e:
ResourceUsage(
os=OperatingSystem.MACOS_SONOMA,
architecture=CPUArchitecture.X86_64,
cpu_usage=[ResourceTimestamped(timestamp=datetime.fromisoformat("2024-09-13"), usage=0.5)],
ram=1,
)
expected_exception = "Unit ram_unit is required when ram is set"
self.assertTrue(expected_exception in repr(e.exception))
resources = ResourceUsage(
os=OperatingSystem.MACOS_SONOMA,
architecture=CPUArchitecture.X86_64,
cpu_usage=[ResourceTimestamped(timestamp=datetime.fromisoformat("2024-09-13"), usage=0.5)],
ram=1,
ram_unit=MemoryUnit.GB,
)
self.assertIsNotNone(resources)
# Check system memory
with self.assertRaises(ValueError) as e:
ResourceUsage(
os=OperatingSystem.MACOS_SONOMA,
architecture=CPUArchitecture.X86_64,
cpu_usage=[ResourceTimestamped(timestamp=datetime.fromisoformat("2024-09-13"), usage=0.5)],
system_memory=1,
)
expected_exception = "Unit system_memory_unit is required when system_memory is set"
self.assertTrue(expected_exception in repr(e.exception))
# Test with no data_processes
# p = Processing(data_processes=[])
# self.assertIsNotNone(p)
def _make_data_process(self, **kwargs) -> DataProcess:
"""Helper to create a minimal DataProcess with overridable fields"""
defaults = dict(
experimenters=["Dr. Dan"],
process_type=ProcessName.COMPRESSION,
stage=ProcessStage.PROCESSING,
code=code,
start_date_time=t,
end_date_time=t,
)
defaults.update(kwargs)
return DataProcess(**defaults)
def test_output_path_none(self):
"""output_path defaults to None when not provided"""
dp = self._make_data_process()
self.assertIsNone(dp.output_path)
def test_output_path_single_string(self):
"""A single string is wrapped into a one-element list of AssetPath"""
dp = self._make_data_process(output_path="./outputs/result.nwb")
self.assertIsInstance(dp.output_path, list)
self.assertEqual(len(dp.output_path), 1)
self.assertIsInstance(dp.output_path[0], AssetPath)
self.assertEqual(str(dp.output_path[0]), "outputs/result.nwb")
def test_output_path_single_asset_path(self):
"""A single AssetPath is wrapped into a one-element list"""
dp = self._make_data_process(output_path=AssetPath("outputs/result.nwb"))
self.assertIsInstance(dp.output_path, list)
self.assertEqual(len(dp.output_path), 1)
self.assertIsInstance(dp.output_path[0], AssetPath)
def test_output_path_list_of_strings(self):
"""A list of strings is converted to a list of AssetPath"""
paths = ["outputs/a.nwb", "outputs/b.nwb"]
dp = self._make_data_process(output_path=paths)
self.assertIsInstance(dp.output_path, list)
self.assertEqual(len(dp.output_path), 2)
for item in dp.output_path:
self.assertIsInstance(item, AssetPath)
self.assertEqual([str(p) for p in dp.output_path], paths)
def test_output_path_list_of_asset_paths(self):
"""A list of AssetPath objects passes through unchanged"""
paths = [AssetPath("outputs/a.nwb"), AssetPath("outputs/b.nwb")]
dp = self._make_data_process(output_path=paths)
self.assertEqual(len(dp.output_path), 2)
for item in dp.output_path:
self.assertIsInstance(item, AssetPath)
def test_unique_process_names(self):
"""Test that process names are unique within a Processing object"""
# Test with duplicate process names
with self.assertRaises(ValueError) as e:
Processing.create_with_sequential_process_graph(
data_processes=[
DataProcess(
experimenters=["Dr. Dan"],
process_type=ProcessName.ANALYSIS,
stage=ProcessStage.ANALYSIS,
start_date_time=t,
end_date_time=t,
code=code,
),
DataProcess(
experimenters=["Dr. Dan"],
process_type=ProcessName.ANALYSIS,
stage=ProcessStage.ANALYSIS,
start_date_time=t,
end_date_time=t,
code=code,
),
]
)
self.assertIn("data_processes must have unique names", str(e.exception))
def test_validate_data_processes(self):
"""Test the validate_data_processes method"""
# Test with valid data_processes
p = Processing.create_with_sequential_process_graph(
data_processes=[
DataProcess(
experimenters=["Dr. Dan"],
process_type=ProcessName.ANALYSIS,
stage=ProcessStage.ANALYSIS,
output_path="./path/to/outputs",
start_date_time=t,
end_date_time=t,
code=code,
),
]
)
self.assertIsNotNone(p)
# Test with data_processes as a list of lists
with self.assertRaises(pydantic.ValidationError):
Processing(
data_processes=[
[
DataProcess(
experimenters=["Dr. Dan"],
process_type=ProcessName.ANALYSIS,
stage=ProcessStage.ANALYSIS,
output_path="./path/to/outputs",
start_date_time=t,
end_date_time=t,
code=code,
),
]
],
dependency_graph={ProcessName.ANALYSIS: []},
)
def test_rename_process(self):
"""Test the rename_process method"""
# Create a processing object with multiple processes
process1 = DataProcess(
name="process1",
experimenters=["Dr. Dan"],
process_type=ProcessName.COMPRESSION,
stage=ProcessStage.PROCESSING,
code=code,
start_date_time=t,
end_date_time=t,
)
process2 = DataProcess(
name="process2",
experimenters=["Dr. Dan"],
process_type=ProcessName.ANALYSIS,
stage=ProcessStage.ANALYSIS,
code=code,
start_date_time=t,
end_date_time=t,
)
process3 = DataProcess(
name="process3",
experimenters=["Dr. Dan"],
process_type=ProcessName.SPIKE_SORTING,
stage=ProcessStage.PROCESSING,
code=code,
start_date_time=t,
end_date_time=t,
)
# Create process graph where process2 depends on process1, and process3 depends on process2
dependency_graph = {
"process1": [],
"process2": ["process1"],
"process3": ["process2"],
}
p = Processing(data_processes=[process1, process2, process3], dependency_graph=dependency_graph)
# Rename process2 to new_name
p.rename_process("process2", "new_name")
# Check that the process was renamed in data_processes
process_names = [proc.name for proc in p.data_processes]
self.assertIn("new_name", process_names)
self.assertNotIn("process2", process_names)
# Check that the process was renamed in dependency_graph keys
self.assertIn("new_name", p.dependency_graph)
self.assertNotIn("process2", p.dependency_graph)
# Check that references to the process were updated in dependency_graph values
self.assertEqual(p.dependency_graph["process3"], ["new_name"])
self.assertEqual(p.dependency_graph["new_name"], ["process1"])
# Test error case - renaming a process that doesn't exist
with self.assertRaises(ValueError) as e:
p.rename_process("non_existent", "another_name")
self.assertIn("not found in data_processes", str(e.exception))
def test_validate_process_graph(self):
"""Test the validate_process_graph method"""
# Create a valid processing object
process1 = DataProcess(
name="process1",
experimenters=["Dr. Dan"],
process_type=ProcessName.COMPRESSION,
stage=ProcessStage.PROCESSING,
code=code,
start_date_time=t,
end_date_time=t,
)
process2 = DataProcess(
name="process2",
experimenters=["Dr. Dan"],
process_type=ProcessName.ANALYSIS,
stage=ProcessStage.ANALYSIS,
code=code,
start_date_time=t,
end_date_time=t,
)
# Valid case - all processes are in dependency_graph and all keys in dependency_graph are processes
dependency_graph = {
"process1": [],
"process2": ["process1"],
}
p = Processing(data_processes=[process1, process2], dependency_graph=dependency_graph)
self.assertIsNotNone(p)
# Invalid case 1 - process in data_processes not in dependency_graph
process3 = DataProcess(
name="process3",
experimenters=["Dr. Dan"],
process_type=ProcessName.SPIKE_SORTING,
stage=ProcessStage.PROCESSING,
code=code,
start_date_time=t,
end_date_time=t,
)
with self.assertRaises(ValueError) as e:
Processing(data_processes=[process1, process2, process3], dependency_graph=dependency_graph)
self.assertIn("dependency_graph must include all processes in data_processes", str(e.exception))
# Invalid case 2 - process in dependency_graph not in data_processes
invalid_graph = {
"process1": [],
"process2": ["process1"],
"process3": ["process2"],
}
with self.assertRaises(ValueError) as e:
Processing(data_processes=[process1, process2], dependency_graph=invalid_graph)
self.assertIn("data_processes must include all processes in dependency_graph", str(e.exception))
def test_dependency_graph_none(self):
"""Tests that no issue is raised if dependency_graph is None"""
processing = Processing(
data_processes=[
DataProcess(
start_date_time=datetime(2024, 10, 10, 1, 2, 3),
end_date_time=datetime(2024, 10, 11, 1, 2, 3),
process_type=ProcessName.COMPRESSION,
experimenters=["AIND Scientific Computing"],
stage=ProcessStage.PROCESSING,
code=Code(
url="www.example.com/ephys_compression",
),
),
DataProcess(
start_date_time=datetime(2024, 10, 10, 1, 2, 3),
end_date_time=datetime(2024, 10, 11, 1, 2, 4),
process_type=ProcessName.OTHER,
experimenters=["AIND Scientific Computing"],
stage=ProcessStage.PROCESSING,
code=Code(url=""),
notes="Data was copied.",
),
]
)
self.assertIsNone(processing.dependency_graph)
def test_validate_pipeline_names(self):
"""Test the validate_pipeline_names method"""
# Create valid pipelines
pipelines = [
Code(name="Pipeline1", url="https://example.com/pipeline1", version="1.0"),
Code(name="Pipeline2", url="https://example.com/pipeline2", version="1.0"),
]
# Create valid data_processes
process1 = DataProcess(
name="process1",
experimenters=["Dr. Dan"],
process_type=ProcessName.COMPRESSION,
stage=ProcessStage.PROCESSING,
code=code,
start_date_time=t,
end_date_time=t,
pipeline_name="Pipeline1",
)
process2 = DataProcess(
name="process2",
experimenters=["Dr. Dan"],
process_type=ProcessName.ANALYSIS,
stage=ProcessStage.ANALYSIS,
code=code,
start_date_time=t,
end_date_time=t,
pipeline_name="Pipeline2",
)
# Valid case
p = Processing(
data_processes=[process1, process2],
dependency_graph={"process1": [], "process2": ["process1"]},
pipelines=pipelines,
)
self.assertIsNotNone(p)
# Invalid case - pipeline_name not in pipelines list
process3 = DataProcess(
name="process3",
experimenters=["Dr. Dan"],
process_type=ProcessName.SPIKE_SORTING,
stage=ProcessStage.PROCESSING,
code=code,
start_date_time=t,
end_date_time=t,
pipeline_name="NonExistentPipeline",
)
with self.assertRaises(ValueError) as e:
Processing(
data_processes=[process1, process2, process3],
dependency_graph={"process1": [], "process2": ["process1"], "process3": ["process2"]},
pipelines=pipelines,
)
self.assertIn("Pipeline name 'NonExistentPipeline' not found in pipelines list", str(e.exception))
def test_order_processes(self):
"""Test the order_processes method"""
# Create processes with different start times (out of order)
t1 = datetime.fromisoformat("2024-09-13T14:00:00")
t2 = datetime.fromisoformat("2024-09-13T12:00:00") # Earlier time
t3 = datetime.fromisoformat("2024-09-13T16:00:00") # Later time
process1 = DataProcess(
name="process1",
experimenters=["Dr. Dan"],
process_type=ProcessName.COMPRESSION,
stage=ProcessStage.PROCESSING,
code=code,
start_date_time=t1,
end_date_time=t1,
)
process2 = DataProcess(
name="process2",
experimenters=["Dr. Dan"],
process_type=ProcessName.ANALYSIS,
stage=ProcessStage.ANALYSIS,
code=code,
start_date_time=t2,
end_date_time=t2,
)
process3 = DataProcess(
name="process3",
experimenters=["Dr. Dan"],
process_type=ProcessName.SPIKE_SORTING,
stage=ProcessStage.PROCESSING,
code=code,
start_date_time=t3,
end_date_time=t3,
)
# Create Processing with out-of-order processes
dependency_graph = {"process1": [], "process2": [], "process3": []}
p = Processing(data_processes=[process1, process2, process3], dependency_graph=dependency_graph)
# Check that processes were reordered by start_date_time
expected_order = [process2, process1, process3] # t2 < t1 < t3
actual_names = [proc.name for proc in p.data_processes]
expected_names = [proc.name for proc in expected_order]
self.assertEqual(actual_names, expected_names)
# Check that notes were updated
self.assertIn("Processes were reordered by start_date_time", p.notes)
# Test with already ordered processes
process4 = DataProcess(
name="process4",
experimenters=["Dr. Dan"],
process_type=ProcessName.COMPRESSION,
stage=ProcessStage.PROCESSING,
code=code,
start_date_time=t1,
end_date_time=t1,
)
process5 = DataProcess(
name="process5",
experimenters=["Dr. Dan"],
process_type=ProcessName.ANALYSIS,
stage=ProcessStage.ANALYSIS,
code=code,
start_date_time=t3,
end_date_time=t3,
)
dependency_graph2 = {"process4": [], "process5": []}
p2 = Processing(data_processes=[process4, process5], dependency_graph=dependency_graph2)
# Check that order wasn't changed and no reordering note was added
self.assertEqual([proc.name for proc in p2.data_processes], ["process4", "process5"])
self.assertIsNone(p2.notes)
# Test with existing notes
dependency_graph3 = {"process1": [], "process2": [], "process3": []}
p3 = Processing(
data_processes=[process1, process2, process3], dependency_graph=dependency_graph3, notes="Existing notes"
)
# Check that reordering note was appended to existing notes
self.assertIn("Existing notes; Processes were reordered by start_date_time", p3.notes)
# Test with empty data_processes
p4 = Processing(data_processes=[], dependency_graph={})
self.assertEqual(len(p4.data_processes), 0)
self.assertIsNone(p4.notes)
if __name__ == "__main__":
unittest.main()