1492 20 olfactometerconfig

[dbirman]

PR moves OlfactometerConfig from stimulus.py to configs.py, leaving just the stimulus_name field in the stimulus classes.

[saskiad]

Don't you need to add OlfactometerConfig to the Acquisition configurations list?

[dbirman]

Don't you need to add OlfactometerConfig to the Acquisition configurations list?

Yes good catch

[dbirman]

• Add a test that checks that all subclasses of DeviceConfig are options in the configurations Union

[saskiad]

I think it looks good - two things that might be worth thinking about but aren't deal breakers.

[saskiad]

@dbirman did this get merged? Do we want it merged?

[dbirman]

• Deprecate old class to avoid making a breaking change
• Add new class to Union[]