Skip to content

1792 quality control validator has a bug at line 307 where it fails to check metrics before doing metrics0 #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbirman merged 2 commits into from
Apr 13, 2026
Merged

1792 quality control validator has a bug at line 307 where it fails to check metrics before doing metrics0 #1793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47f5972
fix: validator would trigger on empty metrics
dbirman Apr 12, 2026
daa80d5
fix: do this upfront by bypassing the validator, adds a test
dbirman Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/aind_data_schema/core/quality_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ def fix_default_grouping_list(cls, value: dict) -> dict:
This function is for backwards compatibility with v2.2.X where default_grouping was stored as a list of strings.
Remove this function in aind-data-schema v3.X
"""
if "default_grouping" not in value:
if "default_grouping" not in value or "metrics" not in value or len(value["metrics"]) == 0:
return value

if all(isinstance(item, str) for item in value["default_grouping"]):
Expand Down
12 changes: 12 additions & 0 deletions tests/test_quality_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,6 +869,18 @@ def test_new_format_default_grouping_mixed(self):
# Tags should remain as dict
self.assertEqual(qc_new.metrics[0].tags, {"group": "test_group", "probe": "probeA", "shank": "shank1"})

def test_empty_metrics_does_not_convert_default_grouping(self):
"""Test that fix_default_grouping_list does not alter default_grouping when metrics is empty"""

empty_metrics_dict = {
"metrics": [],
"default_grouping": ["group1", "group2"],
}

qc = QualityControl.model_validate(empty_metrics_dict)

self.assertEqual(qc.default_grouping, ["group1", "group2"])


if __name__ == "__main__":
unittest.main()
Loading