fix: add Reagent as an option for Acquisition.manipulations#1797
Merged
dbirman merged 14 commits intoMay 15, 2026
Merged
Conversation
This reverts commit 28d430e.
…specimenprocedure-for-hcr' of https://github.com/AllenNeuralDynamics/aind-data-schema into 1796-add-to-acquisitionmanipulations-discriminatedlist-specimenprocedure-for-hcr
Member
Author
|
Add optional protocol_id to Manipulation, only Reagent as option |
saskiad
reviewed
Apr 23, 2026
saskiad
reviewed
Apr 23, 2026
saskiad
approved these changes
Apr 23, 2026
dbirman
changed the title
…natedlist-specimenprocedure-for-hcr
…natedlist-specimenprocedure-for-hcr
dbirman
deleted the
1796-add-to-acquisitionmanipulations-discriminatedlist-specimenprocedure-for-hcr
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Reagent as an option for Acquisition.manipulations and an optional protocol_id list field to the Manipulation class. It also refactors
protocol_idas a Mixin class that we include in various places. I was getting a little worried about duplicating this field all over the place, this ensures that the field always looks exactly the same with the same description.