chore: build ISI instrument example#1833
Conversation
| ) | ||
|
|
||
| isi_lens_35mm = Lens( | ||
| name="Nikon NIKKOR 35mm f/1.4", |
There was a problem hiding this comment.
this is a nice to have: I think having the name contain the full model number isn't best practice. It's not really bad, but it sets a precedent of doing this, and we want to avoid people cramming metadata into names instead of using other fields. I know if this case, we need to distinguish the two nikon lens, but we don't need the full manufacturer/model in the device name. Could be "lens 35mm" or something.
Kind of the same with the camera above too.
| ) | ||
|
|
||
| isi_bandpass_filter = Filter( | ||
| name="Semrock FF01-630/92-50 Bandpass Filter", |
There was a problem hiding this comment.
this is prime example of above. We already have the bandapass and center wavelength in real fields. Make this simpler.
| eye_tracking_camera_assembly = CameraAssembly( | ||
| name="Eye Tracking Camera Assembly", | ||
| target=CameraTarget.EYE, | ||
| relative_position=[AnatomicalRelative.ANTERIOR], |
There was a problem hiding this comment.
usually eye tracking isn't done from the anterior...
| ) | ||
|
|
||
| led_ring_green = LightEmittingDiode( | ||
| name="LED Ring Green 527nm", |
There was a problem hiding this comment.
keep the color, remvoe the wavelength from the name.
| ) | ||
|
|
||
| stimulus_monitor = Monitor( | ||
| name="ASUS PA248Q Stimulus Monitor", |
There was a problem hiding this comment.
just "Stimulus Monitor" works fine here
saskiad
left a comment
saskiad
left a comment
There was a problem hiding this comment.
I'll allow it, but I'd love to make the device names simpler so that people don't see this as how this should be done. Also makes it harder to work with during acqusition when the device names are long and detailed.
2 participants
Adds an ISI instrument example, this will be used to backfill all existing ISI records. There are three ISI rigs, "ISIV.1" "ISIV.2" and "ISIV.3" that show up in existing data assets, unfortunately variations between them aren't captured here but I'm told they are basically identical.
Small note: the existing session metadata has a device listed "ISI LED" but since the actual rig has two LEDs I think the simplest thing is as part of the migration we will rename the field in the device configuration. This way we can have more informative names in the instrument metadata.