Skip to content

feat: add name field to DataAsset (#1787)#1836

Merged
tmchartrand merged 3 commits into
devfrom
1787-fix-dataprocessinput_data-to-match-datadescriptionsource_data
May 21, 2026
Merged

feat: add name field to DataAsset (#1787)#1836
tmchartrand merged 3 commits into
devfrom
1787-fix-dataprocessinput_data-to-match-datadescriptionsource_data

Conversation

@tmchartrand

Copy link
Copy Markdown
Member

infers name from url if in s3://aind-open-data/

I chose not to add a validation pattern to the name field since I assume we want to allow inputs matching old or new name patterns. Let me know if that would be preferred instead.

@tmchartrand tmchartrand requested a review from dbirman May 19, 2026 17:52
infers name from url if in s3://aind-open-data/
@tmchartrand tmchartrand force-pushed the 1787-fix-dataprocessinput_data-to-match-datadescriptionsource_data branch from 7d07d04 to 0ca8ca0 Compare May 19, 2026 18:16

@dbirman dbirman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, small lint fix you need to do still

@tmchartrand tmchartrand changed the title add name field to DataAsset (#1787) feat: add name field to DataAsset (#1787) May 21, 2026
@tmchartrand tmchartrand added this pull request to the merge queue May 21, 2026
Merged via the queue into dev with commit b2397e4 May 21, 2026
6 checks passed
@tmchartrand tmchartrand deleted the 1787-fix-dataprocessinput_data-to-match-datadescriptionsource_data branch May 21, 2026 17:42
@tmchartrand tmchartrand linked an issue May 28, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix DataProcess.input_data to match DataDescription.source_data

2 participants