Skip to content

feat: Metadata.from_metadata#1852

Open
dbirman wants to merge 6 commits into
devfrom
1845-docs-page-for-metadata-inheritance
Open

feat: Metadata.from_metadata#1852
dbirman wants to merge 6 commits into
devfrom
1845-docs-page-for-metadata-inheritance

Conversation

@dbirman

@dbirman dbirman commented Jun 4, 2026

Copy link
Copy Markdown
Member

This PR adds a new function Metadata.from_metadata that simplifies the process of generating derived asset metadata. It implements four rules (see the docs page) that control how metadata is inherited.

@dbirman dbirman linked an issue Jun 4, 2026 that may be closed by this pull request
@dbirman dbirman requested review from saskiad and tmchartrand June 15, 2026 00:47

@tmchartrand tmchartrand left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look through in a bit more detail later, but one high-level thought:
I think we should clarify that we still want to inherit subject metadata if there are additional input assets without subject metadata (ie aggregated reference data, templates or the like) in addition to the single-subject assets (and same for sessions).

Does that make sense @saskiad @dbirman ?

@dbirman

dbirman commented Jun 15, 2026

Copy link
Copy Markdown
Member Author

I'll look through in a bit more detail later, but one high-level thought: I think we should clarify that we still want to inherit subject metadata if there are additional input assets without subject metadata (ie aggregated reference data, templates or the like) in addition to the single-subject assets (and same for sessions).

Does that make sense @saskiad @dbirman ?

For example, if someone uses the CCF to do registration that doesn't mean their derived asset is "multi-subject"? I agree we can add that clarification.

@tmchartrand

Copy link
Copy Markdown
Member

Cool I'm pretty sure the code handles this correctly as-is, but we should update docstrings and docs pages and maybe have explicit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs page for metadata inheritance

2 participants