Skip to content

foraging_efficiency is a metric that should be moved to metrics folder#66

Merged
rachelstephlee merged 4 commits into
mainfrom
move_foraging_eff
Jun 9, 2025
Merged

foraging_efficiency is a metric that should be moved to metrics folder#66
rachelstephlee merged 4 commits into
mainfrom
move_foraging_eff

Conversation

@rachelstephlee

Copy link
Copy Markdown
Collaborator

No description provided.

@rachelstephlee rachelstephlee requested a review from hanhou June 4, 2025 00:54
@rachelstephlee

Copy link
Copy Markdown
Collaborator Author

@hanhou , somehow init isn't finding the new location. is it necessary to import it in init.py ?

@hanhou

hanhou commented Jun 5, 2025

Copy link
Copy Markdown
Collaborator

somehow init isn't finding the new location

You should either import it from aind_dynamic_foraging_basic_analysis.metrics.**foraging_efficiency** or just aind_dynamic_foraging_basic_analysis (see below)

is it necessary to import it in init.py

This makes from aind_dynamic_foraging_basic_analysis import compute_foraging_efficiency always work regardless of the location of foraging_efficiency.py. It appears that all the dependent AIND repos imports the function this way, so we don't have to change aynthing else!

image

@rachelstephlee rachelstephlee merged commit 13339cf into main Jun 9, 2025
3 checks passed
@alexpiet alexpiet deleted the move_foraging_eff branch September 4, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants