test: update tests

Author: arjunsridhar12345

tests/test_qc/test_behavior.py

@@ -43,37 +43,26 @@ def test_calculate_lick_intervals_detects_artifacts():
     assert result["ArtifactPercent"] > 0
 
 
-def test_compute_side_bias_balanced_and_all_ignore():
-    """Bias is right-minus-left over responses; all-ignore gives nan."""
-    assert _behavior.compute_side_bias(np.array([0, 1, 0, 1])) == 0.0
-    assert _behavior.compute_side_bias(np.array([1, 1, 1, 0])) == pytest.approx(0.5)
-    assert np.isnan(_behavior.compute_side_bias(np.array([2, 2, 2])))
-
-
-def test_compute_rolling_bias_shapes_and_empty_window():
-    """Rolling bias is nan where a window has no responses, set otherwise."""
-    responses = np.array([2, 1, 1, 0])  # first trial is ignore -> nan
-    bias, ci = _behavior.compute_rolling_bias(responses, window=2)
-    assert bias.shape == (4,)
-    assert ci.shape == (4, 2)
-    assert np.isnan(bias[0])
-    assert not np.isnan(bias[1])
-
-
 def test_side_bias_result_pass_and_fail():
-    """Side-bias result passes under 0.5 absolute bias and fails above it."""
-    passing = _behavior.side_bias_result(np.array([0, 1, 0, 1]))
+    """Side-bias result averages the column; passes under 0.5 absolute bias."""
+    passing = _behavior.side_bias_result(np.array([-0.2, 0.1, np.nan, 0.1]))
     assert passing.passed is True
+    assert passing.value == pytest.approx(0.0)
     assert passing.reference == _behavior.SIDE_BIAS_PLOT
     assert passing.tags == {"behavior": "average side bias"}
 
-    failing = _behavior.side_bias_result(np.array([1, 1, 1, 1]))
+    failing = _behavior.side_bias_result(np.array([0.8, 0.9, 1.0]))
     assert failing.passed is False
+    assert failing.value == pytest.approx(0.9)
 
-    no_response = _behavior.side_bias_result(np.array([2, 2, 2]))
+    no_response = _behavior.side_bias_result(np.array([np.nan, np.nan]))
     assert no_response.passed is False
     assert np.isnan(no_response.value)
 
+    empty = _behavior.side_bias_result(np.array([]))
+    assert empty.passed is False
+    assert np.isnan(empty.value)
+
 
 def test_lick_interval_results_names_and_count():
     """Four lick-interval results are produced with the expected names/tags."""

tests/test_qc/test_builder.py

@@ -14,7 +14,10 @@
 def test_behavior_qc_results_without_plots():
     """Five behavior results are produced and no plots are written."""
     results = _results.behavior_qc_results(
-        np.array([0, 1, 2, 1]), np.array([1.0, 1.01]), np.array([2.0, 2.01])
+        np.array([0, 1, 2, 1]),
+        np.array([-0.1, 0.0, np.nan, 0.1]),
+        np.array([1.0, 1.01]),
+        np.array([2.0, 2.01]),
     )
     assert len(results) == 5
     assert results[0].name == "average side bias"
@@ -24,6 +27,7 @@ def test_behavior_qc_results_writes_plots(tmp_path):
     """Supplying a results folder writes both behavior plots."""
     results = _results.behavior_qc_results(
         np.array([0, 1, 2, 1]),
+        np.array([-0.1, 0.0, np.nan, 0.1]),
         np.array([1.0, 1.01]),
         np.array([2.0, 2.01]),
         str(tmp_path),
@@ -36,7 +40,9 @@ def test_behavior_qc_results_writes_plots(tmp_path):
 def test_build_quality_control_defaults():
     """Defaults fill in the standard grouping and an empty failure allowlist."""
     metrics = to_metrics(
-        _results.behavior_qc_results(np.array([0, 1]), np.array([1.0]), np.array([2.0]))
+        _results.behavior_qc_results(
+            np.array([0, 1]), np.array([0.1, -0.1]), np.array([1.0]), np.array([2.0])
+        )
     )
     qc = _builder.build_quality_control(metrics)
     assert isinstance(qc, QualityControl)
@@ -47,7 +53,9 @@ def test_build_quality_control_defaults():
 def test_build_quality_control_overrides():
     """Explicit grouping / allowlist / metadata are passed through."""
     metrics = to_metrics(
-        _results.behavior_qc_results(np.array([0, 1]), np.array([1.0]), np.array([2.0]))
+        _results.behavior_qc_results(
+            np.array([0, 1]), np.array([0.1, -0.1]), np.array([1.0]), np.array([2.0])
+        )
     )
     qc = _builder.build_quality_control(
         metrics,

tests/test_qc/test_plots.py

@@ -28,8 +28,10 @@ def test_time_to_trial_index_covers_all_branches():
 def test_plot_side_bias_full_inputs(tmp_path):
     """All optional panels render when every per-trial array is supplied."""
     animal_response = np.array([0, 1, 2, 1, 0, 1])
+    side_bias = np.array([-0.2, 0.0, np.nan, 0.3, 0.1, 0.2])
     name = _plots.plot_side_bias(
         animal_response,
+        side_bias,
         str(tmp_path),
         lickspout_x=np.array([1.0, 1.1, 1.0, 1.2, 1.1, 1.0]),
         lickspout_y1=np.array([2.0, 2.0, 2.1, 2.0, 2.0, 2.1]),
@@ -44,19 +46,20 @@ def test_plot_side_bias_full_inputs(tmp_path):
         autowater_right=np.array([0, 0, 0, 1, 0, 0]),
         manual_left_times=np.array([0.1, 3.6]),  # 0.1 -> -1, 3.6 -> trial index
         manual_right_times=np.array([5.6]),
-        bias_window=3,
     )
     assert name == _plots.SIDE_BIAS_PLOT
     assert os.path.exists(tmp_path / name)
 
 
 def test_plot_side_bias_minimal_inputs(tmp_path):
     """With only choices supplied, the optional panels are skipped cleanly."""
-    name = _plots.plot_side_bias(np.array([]), str(tmp_path))
+    name = _plots.plot_side_bias(np.array([]), np.array([]), str(tmp_path))
     assert os.path.exists(tmp_path / name)
 
 
 def test_plot_side_bias_empty_position_array(tmp_path):
     """An empty lickspout-position array is skipped without plotting."""
-    name = _plots.plot_side_bias(np.array([0, 1]), str(tmp_path), lickspout_x=np.array([]))
+    name = _plots.plot_side_bias(
+        np.array([0, 1]), np.array([0.1, -0.1]), str(tmp_path), lickspout_x=np.array([])
+    )
     assert os.path.exists(tmp_path / name)

tests/test_qc/test_stages.py

@@ -46,7 +46,10 @@ def _fake_contract_qc_metrics(dataset, results_folder):
 def test_processed_qc_run_returns_metrics():
     """``ProcessedQC.run`` produces the five behavior metrics."""
     metrics = ProcessedQC().run(
-        np.array([0, 1, 2, 1]), np.array([1.0, 1.01]), np.array([2.0, 2.01])
+        np.array([0, 1, 2, 1]),
+        np.array([-0.1, 0.0, np.nan, 0.1]),
+        np.array([1.0, 1.01]),
+        np.array([2.0, 2.01]),
     )
     assert len(metrics) == 5
     assert all(isinstance(m, QCMetric) for m in metrics)
@@ -57,6 +60,7 @@ def test_processed_qc_run_writes_plots(tmp_path):
     """Supplying a results folder writes the supporting plots."""
     metrics = ProcessedQC().run(
         np.array([0, 1, 2, 1]),
+        np.array([-0.1, 0.0, np.nan, 0.1]),
         np.array([1.0, 1.01]),
         np.array([2.0, 2.01]),
         str(tmp_path),