refactor: remove proxy, CORS is fixed

Author: dbirman

deploy/nginx.conf

@@ -34,17 +34,6 @@ server {
         proxy_set_header   X-Forwarded-For  $proxy_add_x_forwarded_for;
     }
 
-    # ------------------------------------------------------------------
-    # S3 data-asset-cache proxy
-    # Avoids CORS — browser fetches squirrel.json from same origin;
-    # nginx forwards to S3.  Mirrors the Vite dev proxy.
-    # ------------------------------------------------------------------
-    location /data-asset-cache/ {
-        proxy_pass         https://allen-data-views.s3.us-west-2.amazonaws.com/data-asset-cache/;
-        proxy_set_header   Host  allen-data-views.s3.us-west-2.amazonaws.com;
-        proxy_ssl_server_name on;
-    }
-
     # ------------------------------------------------------------------
     # duckdb-server WebSocket proxy
     # Strips the /ws prefix — duckdb-server listens at its root path.

web/src/__tests__/constants.test.js

@@ -30,6 +30,7 @@ describe('constants', () => {
   });
 
   it('SQUIRREL_URL points to the squirrel.json metadata file', () => {
+    expect(SQUIRREL_URL).toContain('allen-data-views');
     expect(SQUIRREL_URL).toContain('data-asset-cache');
     expect(SQUIRREL_URL).toContain('squirrel.json');
   });

web/src/constants.js

@@ -20,13 +20,8 @@ export const S3_BUCKET = 'allen-data-views';
 /**
  * URL of the squirrel JSON metadata file.
  * Fetched once at startup to discover all available datasets ("acorns").
- *
- * Always uses a same-origin relative path so the browser never makes a
- * cross-origin request to S3:
- *   - Development: Vite proxies /data-asset-cache → S3.
- *   - Production:  nginx proxies /data-asset-cache → S3 (see deploy/nginx.conf).
  */
-export const SQUIRREL_URL = '/data-asset-cache/squirrel.json';
+export const SQUIRREL_URL = `https://${S3_BUCKET}.s3.${S3_REGION}.amazonaws.com/data-asset-cache/squirrel.json`;
 
 // ---------------------------------------------------------------------------
 // AIND brand colours (ported from src/zombie/layout.py)

web/vite.config.js

@@ -13,12 +13,6 @@ export default defineConfig({
         target: 'http://localhost:3001',
         rewrite: (path) => path.replace(/^\/docdb/, ''),
       },
-      // Forward /data-asset-cache/* to the public S3 bucket (avoids CORS
-      // in development; production uses the direct S3 URL).
-      '/data-asset-cache': {
-        target: 'https://allen-data-views.s3.us-west-2.amazonaws.com',
-        changeOrigin: true,
-      },
     },
   },