-
Notifications
You must be signed in to change notification settings - Fork 0
Test calvinshum dev #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
8037235
5ba4dc9
5e3d9a8
32fe251
095dd3e
74aa47d
5e11aa7
aef9a54
4a88546
1917c72
a118b67
9ccb50b
624f0e8
663ecae
e425f16
1a6688e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -331,3 +331,7 @@ | |
| # TLS Management Consts | ||
| CONST_TLS_MANAGEMENT_MANAGED = "Managed" | ||
| CONST_TLS_MANAGEMENT_NONE = "None" | ||
|
|
||
| # GPU Driver Type Consts | ||
| CONST_GPU_DRIVER_TYPE_CUDA = "CUDA" | ||
| CONST_GPU_DRIVER_TYPE_GRID = "GRID" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔎 from enum import Enum
class TlsManagement(Enum):
MANAGED = "Managed"
NONE = "None"
class GpuDriverType(Enum):
CUDA = "CUDA"
GRID = "GRID" |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1861,6 +1861,9 @@ | |
| - name: --skip-gpu-driver-install | ||
| type: bool | ||
| short-summary: To skip GPU driver auto installation by AKS on a nodepool using GPU vm size if customers want to manage GPU driver installation by their own. If not specified, the default is false. | ||
| - name: --driver-type | ||
| type: string | ||
| short-summary: Specify the type of GPU driver to install when creating Windows agent pools. Valid values are "GRID" and "CUDA". If not provided, AKS selects the driver based on system compatibility. This option cannot be changed once the AgentPool has been created. The default is system selected. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔎 - short-summary: Specify the type of GPU driver to install when creating Windows agent pools. Valid values are "GRID" and "CUDA".
+ short-summary: Specify the type of GPU driver to install when creating Windows agent pools. Valid values are `GRID` and `CUDA`. |
||
| - name: --ssh-access | ||
| type: string | ||
| short-summary: Configure SSH setting for the node pool. Use "disabled" to disable SSH access, "localuser" to enable SSH access using private key. | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1215,6 +1215,7 @@ def aks_agentpool_add( | |
| node_public_ip_tags=None, | ||
| enable_artifact_streaming=False, | ||
| skip_gpu_driver_install=False, | ||
| driver_type=None, | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔎 if driver_type is not None:
# Validate driver_type options or set default if needed
valid_driver_types = ['type1', 'type2']
if driver_type not in valid_driver_types:
raise ValueError(f"Invalid driver_type: {driver_type}. Must be one of {valid_driver_types}") |
||
| ssh_access=CONST_SSH_ACCESS_LOCALUSER, | ||
| # trusted launch | ||
| enable_secure_boot=False, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎
Please ensure to format the placeholder and URLs properly as per the guidelines:
+To release a new version, please select a new version number (usually plus 1 to last patch version, X.Y.Z -> Major.Minor.Patch, more details in `\doc <https://semver.org/>`_), and then add a new section named as the new version number in this file, the content should include the new modifications and everything from the *Pending* section. Finally, update the `VERSION` variable in `setup.py` with this new version number.\doc <https://semver.org/>_ with appropriate surrounding HTML tags or use backticks for placeholders and ensure the URL link is marked as an example if not accessible.