uploaders/pulp: parallel chunks, direct artifacts, config concurrency#179
Open
andrewlukoshko wants to merge 1 commit intomasterfrom
Open
uploaders/pulp: parallel chunks, direct artifacts, config concurrency#179andrewlukoshko wants to merge 1 commit intomasterfrom
andrewlukoshko wants to merge 1 commit intomasterfrom
Conversation
- Replace sequential filesplit-based disk splitting with parallel ThreadPoolExecutor chunk uploads using byte-range reads via temp files - Add direct artifact creation via ArtifactsApi.create() for files smaller than chunk_size, bypassing the 3-step upload+commit flow - Add configurable upload_workers setting (default 4) to SignNodeConfig, wired through Signer to PulpBaseUploader - Add per-file upload timing logs at INFO level for all three upload paths (direct artifact, single chunk, multi-chunk) - Remove filesplit dependency from requirements.txt - Add 6 new tests: parallel chunk upload, chunk error propagation, direct artifact creation, configurable workers, default workers, and upload timing log verification
andrewlukoshko
changed the title
andrewlukoshko
force-pushed
the
feat-optimize-files-upload
branch
from
1e9da96 to
73dc58a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulp Upload Benchmark Results
Server: pulpcore 3.68.1 (Docker
pulp/pulp:3.68)Client: pulpcore-client 3.68.0
Chunk size: 8 MB
Upload workers: 4 (ThreadPoolExecutor)
Iterations: 3 per scenario
Old vs New Upload Path
Concurrency Scaling (500 MB file, 63 chunks)