Fix chat links

Author: alexiri

astra_app/core/chatnicknames.py

@@ -201,6 +201,9 @@ def build_chat_nickname_link(value: str, *, scheme_override: str | None = None)
                 display = f"{display}@{server}"
             return ChatNicknameLink(href=href, title=title, display=display)
 
+        if not _IRC_NICK_RE.match(nick):
+            return None
+
         href = f"irc://{server}/{nick},isnick"
         title = f"IRC on {server}"
         display = nick
@@ -209,37 +212,47 @@ def build_chat_nickname_link(value: str, *, scheme_override: str | None = None)
         return ChatNicknameLink(href=href, title=title, display=display)
 
     if scheme == ChatScheme.matrix:
+        localpart = nick.lstrip("@")
+        if not _MATRIX_LOCALPART_RE.match(localpart):
+            return None
+
         args = settings.CHAT_MATRIX_TO_ARGS
         args = args if isinstance(args, str) and args else ""
 
-        href = f"https://matrix.to/#/@{nick}:{server}"
+        href = f"https://matrix.to/#/@{localpart}:{server}"
         if args:
             href = f"{href}?{args}"
 
         title = f"Matrix on {server}"
 
-        display = f"@{nick}"
+        display = f"@{localpart}"
         if not default_server or server != default_server:
             display = f"{display}:{server}"
 
         return ChatNicknameLink(href=href, title=title, display=display, external=True)
 
     if scheme == ChatScheme.mattermost:
+        if not _SERVER_RE.match(server) or not _MATTERMOST_USERNAME_RE.match(nick):
+            return None
+
         if not team:
             # For default server we can fall back to the configured default team.
             if default_server and server == default_server and default_team:
                 team = default_team
             else:
                 return None
 
+        if not _MATTERMOST_TEAM_RE.match(team):
+            return None
+
         href = f"https://{server}/{team}/messages/@{nick}"
         title = f"Mattermost on {server} ({team})"
 
         display = f"@{nick}"
         if (default_server and server != default_server) or (default_team and team != default_team) or (not default_server) or (not default_team):
             display = f"@{nick}:{server}:{team}"
 
-        return ChatNicknameLink(href=href, title=title, display=display)
+        return ChatNicknameLink(href=href, title=title, display=display, external=True)
 
     return None
 
@@ -405,6 +418,9 @@ def build_chat_channel_link(value: str, *, scheme_override: str | None = None) -
         if not channel or not server:
             return None
 
+        if not _SERVER_RE.match(server) or not _MATTERMOST_CHANNEL_RE.match(channel):
+            return None
+
         default_server = _get_default_server(ChatScheme.mattermost) or ""
         default_team = _get_default_team() or ""
 
@@ -414,14 +430,17 @@ def build_chat_channel_link(value: str, *, scheme_override: str | None = None) -
             else:
                 return None
 
+        if not _MATTERMOST_TEAM_RE.match(team):
+            return None
+
         href = f"https://{server}/{team}/channels/{channel}"
         title = f"Mattermost channel on {server} ({team})"
 
         display = f"~{channel}"
         if (default_server and server != default_server) or (default_team and team != default_team) or (not default_server) or (not default_team):
             display = f"~{channel}:{server}:{team}"
 
-        return ChatChannelLink(href=href, title=title, display=display)
+        return ChatChannelLink(href=href, title=title, display=display, external=True)
 
     if not channel or not server:
         return None

astra_app/core/templates/core/group_detail.html

@@ -18,6 +18,11 @@
     data-group-detail-leaders-api-url="{% url 'api-group-detail-leaders' group.cn %}"
     data-group-detail-members-api-url="{% url 'api-group-detail-members' group.cn %}"
     data-group-detail-action-url="{% url 'api-group-action' group.cn %}"
+    data-group-detail-chat-irc-default-server="{{ chat_irc_default_server }}"
+    data-group-detail-chat-matrix-default-server="{{ chat_matrix_default_server }}"
+    data-group-detail-chat-mattermost-default-server="{{ chat_mattermost_default_server }}"
+    data-group-detail-chat-mattermost-default-team="{{ chat_mattermost_default_team }}"
+    data-group-detail-chat-matrix-to-args="{{ chat_matrix_to_args }}"
     data-group-detail-current-username="{{ request.user.get_username }}"
     data-group-detail-url-template="{{ group_detail_url_template }}"
     data-group-detail-edit-url-template="{{ group_edit_url_template }}"

astra_app/core/templates/core/user_profile.html

@@ -15,6 +15,11 @@
   <div
     data-user-profile-root
     data-user-profile-api-url="{% url 'api-user-profile-detail' profile_username %}"
+    data-user-profile-chat-irc-default-server="{{ chat_irc_default_server }}"
+    data-user-profile-chat-matrix-default-server="{{ chat_matrix_default_server }}"
+    data-user-profile-chat-mattermost-default-server="{{ chat_mattermost_default_server }}"
+    data-user-profile-chat-mattermost-default-team="{{ chat_mattermost_default_team }}"
+    data-user-profile-chat-matrix-to-args="{{ chat_matrix_to_args }}"
     data-user-profile-settings-profile-url="{{ settings_profile_url }}"
     data-user-profile-settings-country-code-url="{{ settings_country_code_url }}"
     data-user-profile-settings-emails-url="{{ settings_emails_url }}"

astra_app/core/templatetags/core_chatnickname.py

@@ -0,0 +1,64 @@
+import json
+from pathlib import Path
+
+from django.test import SimpleTestCase, override_settings
+
+from core.chatnicknames import build_chat_channel_link, build_chat_nickname_link
+
+
+def _parity_fixture_path() -> Path:
+    return Path(__file__).resolve().parents[3] / "frontend" / "src" / "shared" / "__tests__" / "fixtures" / "chatLinkParityCases.json"
+
+
+def _load_parity_fixture() -> dict[str, object]:
+    return json.loads(_parity_fixture_path().read_text(encoding="utf-8"))
+
+
+@override_settings(
+    CHAT_NETWORKS={
+        "irc": {"default_server": "irc.libera.chat"},
+        "matrix": {"default_server": "matrix.org"},
+        "mattermost": {
+            "default_server": "chat.almalinux.org",
+            "default_team": "almalinux",
+        },
+    },
+    CHAT_MATRIX_TO_ARGS="web-instance[element.io]=app.element.io",
+)
+class ChatLinkParityTests(SimpleTestCase):
+    def test_python_builders_match_the_shared_parity_fixture(self) -> None:
+        fixture = _load_parity_fixture()
+        cases = fixture["cases"]
+
+        self.assertIsInstance(cases, list)
+
+        for case in cases:
+            self.assertIsInstance(case, dict)
+            raw = case["raw"]
+            kind = case["kind"]
+            expected = case["expected"]
+
+            self.assertIsInstance(raw, str)
+            self.assertIn(kind, {"nickname", "channel"})
+
+            link = (
+                build_chat_nickname_link(raw)
+                if kind == "nickname"
+                else build_chat_channel_link(raw)
+            )
+
+            with self.subTest(case=case["id"]):
+                if expected is None:
+                    self.assertIsNone(link)
+                    continue
+
+                self.assertIsNotNone(link)
+                self.assertEqual(
+                    {
+                        "href": link.href,
+                        "title": link.title,
+                        "display": link.display,
+                        "external": link.external,
+                    },
+                    expected,
+                )

astra_app/core/tests/test_chat_link_parity.py

@@ -42,6 +42,11 @@ def test_group_detail_renders_chat_channels_links(self) -> None:
         self.assertEqual(resp.status_code, 200)
         self.assertContains(resp, "data-group-detail-root")
         self.assertContains(resp, reverse("api-group-detail-info", args=["fas1"]))
+        self.assertContains(resp, 'data-group-detail-chat-irc-default-server="irc.libera.chat"')
+        self.assertContains(resp, 'data-group-detail-chat-matrix-default-server="matrix.org"')
+        self.assertContains(resp, 'data-group-detail-chat-mattermost-default-server="chat.almalinux.org"')
+        self.assertContains(resp, 'data-group-detail-chat-mattermost-default-team="almalinux"')
+        self.assertContains(resp, 'data-group-detail-chat-matrix-to-args="web-instance[element.io]=app.element.io"')
         self.assertEqual(info_resp.status_code, 200)
         self.assertEqual(
             info_resp.json()["group"]["fas_irc_channels"],

astra_app/core/tests/test_group_detail_renders_chat_channels.py

@@ -63,6 +63,11 @@ def test_user_profile_page_renders_vue_controller_shell_contract(self) -> None:
         self.assertContains(response, 'data-user-profile-membership-notes-can-write="false"')
         self.assertContains(response, 'data-user-profile-group-detail-url-template="/group/__group_name__/"')
         self.assertContains(response, 'data-user-profile-agreements-url-template="/settings/?tab=agreements&agreement=__agreement_cn__"')
+        self.assertContains(response, 'data-user-profile-chat-irc-default-server="irc.libera.chat"')
+        self.assertContains(response, 'data-user-profile-chat-matrix-default-server="matrix.org"')
+        self.assertContains(response, 'data-user-profile-chat-mattermost-default-server="chat.almalinux.org"')
+        self.assertContains(response, 'data-user-profile-chat-mattermost-default-team="almalinux"')
+        self.assertContains(response, 'data-user-profile-chat-matrix-to-args="web-instance[element.io]=app.element.io"')
         self.assertContains(response, 'src="http://localhost:5173/src/entrypoints/userProfile.ts"')
         self.assertNotContains(response, "data-user-profile-summary-root")
         self.assertNotContains(response, "user-profile-summary-bootstrap")
@@ -238,6 +243,10 @@ def test_user_profile_detail_api_returns_data_only_payload(self) -> None:
         self.assertEqual(payload["summary"]["username"], username)
         self.assertNotIn("currentTimeLabel", payload["summary"])
         self.assertEqual(payload["summary"]["countryCode"], "US")
+        self.assertEqual(payload["summary"]["ircNicks"], ["aliceirc"])
+        self.assertTrue(all(isinstance(nick, str) for nick in payload["summary"]["ircNicks"]))
+        self.assertNotIn("chatLinks", payload["summary"])
+        self.assertNotIn("ircNickLinks", payload["summary"])
         self.assertNotIn("profileCountry", payload["summary"])
         self.assertEqual(payload["summary"]["socialProfiles"], [{"platform": "x", "urls": ["https://x.com/alice"]}])
         self.assertNotIn("label", payload["summary"]["socialProfiles"][0])

astra_app/core/tests/test_user_profile_vue.py

@@ -25,6 +25,7 @@
     _normalize_str,
     agreement_settings_url,
     build_page_url_prefix,
+    chat_link_bootstrap_context,
     get_username,
     normalize_freeipa_group_name,
     paginate_and_build_context,
@@ -304,6 +305,7 @@ def group_detail(request: HttpRequest, name: str) -> HttpResponse:
                 "placeholder-agreement", "__agreement_cn__"
             ),
             "agreements_list_url": agreement_settings_url(None),
+            **chat_link_bootstrap_context(),
         },
     )
 

astra_app/core/views_groups.py

@@ -44,6 +44,7 @@
 from core.views_utils import (
     _normalize_str,
     agreement_settings_url,
+    chat_link_bootstrap_context,
     get_username,
     normalize_freeipa_username,
     settings_url,
@@ -1192,6 +1193,7 @@ def user_profile(request: HttpRequest, username: str) -> HttpResponse:
             "membership_notes_add_url": reverse("api-membership-notes-aggregate-add"),
             "membership_notes_can_view": membership_can_view,
             "membership_notes_can_write": membership_can_write,
+            **chat_link_bootstrap_context(),
         },
     )
 

astra_app/core/views_users.py

@@ -243,6 +243,16 @@ def agreement_settings_url(agreement_cn: str | None, *, return_to: str | None =
     return settings_url(tab="agreements", agreement=agreement_cn_value, return_to=return_to)
 
 
+def chat_link_bootstrap_context() -> dict[str, str]:
+    return {
+        "chat_irc_default_server": settings.CHAT_NETWORKS["irc"]["default_server"],
+        "chat_matrix_default_server": settings.CHAT_NETWORKS["matrix"]["default_server"],
+        "chat_mattermost_default_server": settings.CHAT_NETWORKS["mattermost"]["default_server"],
+        "chat_mattermost_default_team": settings.CHAT_NETWORKS["mattermost"]["default_team"],
+        "chat_matrix_to_args": settings.CHAT_MATRIX_TO_ARGS,
+    }
+
+
 def block_action_without_country_code(
     request: HttpRequest,
     *,