Remove duplicate loading message

Author: alexiri

astra_app/core/templates/core/membership_requests.html

@@ -105,16 +105,10 @@ <h1 class="m-0">Membership Requests</h1>
               <th class="text-right" style="width: 15%;">Actions</th>
             </tr>
           </thead>
-          <tbody>
-            <tr>
-              <td colspan="5" class="p-3 text-muted">Loading pending requests...</td>
-            </tr>
-          </tbody>
         </table>
       </div>
 
       <div class="p-3 border-top">
-        <div class="float-left text-muted small" id="membership-requests-pending-info">Loading pending requests...</div>
         <ul class="pagination pagination-sm m-0 float-right" id="membership-requests-pending-pager" aria-label="Pending pagination"></ul>
       </div>
     </div>
@@ -172,16 +166,10 @@ <h3 class="mt-4 mb-2">Waiting for requester response</h3>
                 <th class="text-right" style="width: 15%;">Actions</th>
               </tr>
             </thead>
-            <tbody>
-              <tr>
-                <td colspan="6" class="p-3 text-muted">Loading on-hold requests...</td>
-              </tr>
-            </tbody>
           </table>
         </div>
 
         <div class="p-3 border-top">
-          <div class="float-left text-muted small" id="membership-requests-on-hold-info">Loading on-hold requests...</div>
           <ul class="pagination pagination-sm m-0 float-right" id="membership-requests-on-hold-pager" aria-label="On-hold pagination"></ul>
         </div>
       </div>

astra_app/core/tests/test_membership_requests_datatables_api.py

@@ -742,8 +742,6 @@ def test_membership_requests_page_renders_datatables_shell(self) -> None:
         self.assertContains(response, 'data-membership-requests-notes-can-view="true"')
         self.assertContains(response, 'data-membership-requests-notes-can-write="true"')
         self.assertContains(response, 'data-membership-requests-notes-can-vote="true"')
-        self.assertContains(response, 'Loading pending requests...')
-        self.assertContains(response, 'Loading on-hold requests...')
         self.assertContains(response, 'id="membership-requests-pending-info"')
         self.assertContains(response, 'id="membership-requests-pending-pager"')
         self.assertContains(response, 'id="membership-requests-on-hold-info"')
@@ -1422,15 +1420,6 @@ class DocumentStub extends EventTarget {{
         def test_script_executes_note_redraw_and_recomputes_bulk_and_modal_next(self) -> None:
                 self._run_node_scenario(
                         """
-                        assert(
-                            document._pendingTbody.innerHTML.includes('Loading pending requests...'),
-                            'Pending table should render a loading placeholder before the first draw completes.',
-                        );
-                        assert(
-                            document._onHoldTbody.innerHTML.includes('Loading on-hold requests...'),
-                            'On-hold table should render a loading placeholder before the first draw completes.',
-                        );
-
                         const bulkNext = bulkForm.querySelector('input[name="next"]');
                         const modalNext = approveModalForm.querySelector('input[name="next"]');
 

astra_app/core/tests/test_membership_requests_on_hold_split.py

@@ -106,8 +106,6 @@ def test_requests_page_renders_pending_and_on_hold_shells(self) -> None:
         self.assertContains(resp, 'id="bulk-action-form-on-hold"')
         self.assertContains(resp, '>On hold since</th>')
         self.assertNotContains(resp, ">Waiting</th>")
-        self.assertContains(resp, "Loading pending requests...")
-        self.assertContains(resp, "Loading on-hold requests...")
         self.assertNotContains(resp, "Request #1")
 
     def test_reject_modal_includes_reason_presets(self) -> None: