More tests.

Author: AlphaOne1

dialects_test.go

@@ -0,0 +1,44 @@
+package dmorph
+
+import (
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func TestDialectStatements(t *testing.T) {
+	// we cannot run tests against all databases, but at least we can test
+	// that the statements for the databases are somehow filled
+	tests := []struct {
+		name   string
+		caller func() BaseDialect
+	}{
+		{name: "DB2", caller: DialectDB2},
+		{name: "MSSQL", caller: DialectMSSQL},
+		{name: "MySQL", caller: DialectMySQL},
+		{name: "Oracle", caller: DialectOracle},
+		{name: "Postgres", caller: DialectPostgres},
+		{name: "SQLite", caller: DialectSQLite},
+	}
+
+	for k, v := range tests {
+		d := v.caller()
+
+		if len(d.CreateTemplate) < 10 {
+			t.Errorf("%v: create template is too short for %v", k, v.name)
+		}
+		assert.Contains(t, d.CreateTemplate, "%s",
+			"no table name placeholder in create template for", v.name)
+
+		if len(d.AppliedTemplate) < 10 {
+			t.Errorf("%v: applied template is too short for %v", k, v.name)
+		}
+		assert.Contains(t, d.AppliedTemplate, "%s",
+			"no table name placeholder in applied template for", v.name)
+
+		if len(d.RegisterTemplate) < 10 {
+			t.Errorf("%v: register template is too short for %v", k, v.name)
+		}
+		assert.Contains(t, d.RegisterTemplate, "%s",
+			"no table name placeholder in register template for", v.name)
+	}
+}

file_migration_test.go

@@ -0,0 +1,59 @@
+package dmorph
+
+import (
+	"database/sql"
+	"io/fs"
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestWithMigrationFromFile(t *testing.T) {
+	dbFile, dbFileErr := prepareDB()
+
+	if dbFileErr != nil {
+		t.Errorf("DB file could not be created: %v", dbFileErr)
+	} else {
+		defer func() { _ = os.Remove(dbFile) }()
+	}
+
+	db, dbErr := sql.Open("sqlite", dbFile)
+
+	if dbErr != nil {
+		t.Errorf("DB file could not be created: %v", dbErr)
+	} else {
+		defer func() { _ = db.Close() }()
+	}
+
+	runErr := Run(db,
+		WithDialect(DialectSQLite()),
+		WithMigrationFromFile("testData/01_base_table.sql"))
+
+	assert.NoError(t, runErr, "did not expect an error")
+}
+
+func TestWithMigrationFromFileError(t *testing.T) {
+	dbFile, dbFileErr := prepareDB()
+
+	if dbFileErr != nil {
+		t.Errorf("DB file could not be created: %v", dbFileErr)
+	} else {
+		defer func() { _ = os.Remove(dbFile) }()
+	}
+
+	db, dbErr := sql.Open("sqlite", dbFile)
+
+	if dbErr != nil {
+		t.Errorf("DB file could not be created: %v", dbErr)
+	} else {
+		defer func() { _ = db.Close() }()
+	}
+
+	runErr := Run(db,
+		WithDialect(DialectSQLite()),
+		WithMigrationFromFile("testData/00_non_existent.sql"))
+
+	var pathErr *fs.PathError
+	assert.ErrorAs(t, runErr, &pathErr, "unexpected error")
+}

migration_test.go

@@ -53,7 +53,7 @@ func TestMigration(t *testing.T) {
 
 	migrationsDir, migrationsDirErr := fs.Sub(testMigrationsDir, "testData")
 
-	assert.Nil(t, migrationsDirErr, "migrations directory could not be opened")
+	assert.NoError(t, migrationsDirErr, "migrations directory could not be opened")
 
 	runErr := Run(db,
 		WithDialect(DialectSQLite()),
@@ -84,7 +84,7 @@ func TestMigrationTooOld(t *testing.T) {
 
 	migrationsDir, migrationsDirErr := fs.Sub(testMigrationsDir, "testData")
 
-	assert.Nil(t, migrationsDirErr, "migrations directory could not be opened")
+	assert.NoError(t, migrationsDirErr, "migrations directory could not be opened")
 
 	runErr := Run(db,
 		WithDialect(DialectSQLite()),
@@ -121,7 +121,7 @@ func TestMigrationUnrelated(t *testing.T) {
 
 	migrationsDir, migrationsDirErr := fs.Sub(testMigrationsDir, "testData")
 
-	assert.Nil(t, migrationsDirErr, "migrations directory could not be opened")
+	assert.NoError(t, migrationsDirErr, "migrations directory could not be opened")
 
 	runErr := Run(db,
 		WithDialect(DialectSQLite()),