Update README.md badges and improve markdown settings#34
Conversation
- Added `noopener noreferrer` to external links for security enhancement. - Replaced outdated GoDoc badge with pkg.go.dev badge. - Disabled and re-enabled specific markdownlint rules for readability. - Updated `.markdownlint.json` to allow longer lines (`MD013`).
WalkthroughThe changes update the markdownlint configuration to enforce a maximum line length of 120 characters and revise the README.md for improved security, updated badge links, and minor formatting adjustments. No functional code or public API changes are present. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.markdownlint.json (1)
1-6: Optional: Tweak MD013 to ignore code blocks/tables to reduce noiseGiven README contains badges, ASCII art, and long code lines, consider excluding code blocks/tables from MD013 to prevent false positives.
Apply this diff:
{ "default": true, "MD003": { "style": "setext_with_atx" }, "MD007": { "indent": 2 }, - "MD013": { "line_length": 120 } + "MD013": { + "line_length": 120, + "heading_line_length": 0, + "code_block_line_length": 0, + "code_blocks": false, + "tables": false + } }README.md (1)
36-41: Nit: Spelling in commented alt textIf you ever re-enable this badge, consider US spelling for consistency: “Practices” instead of “Practises”.
- alt="OpenSSF Best Practises"> + alt="OpenSSF Best Practices">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.markdownlint.json(1 hunks)README.md(4 hunks)
🔇 Additional comments (5)
.markdownlint.json (1)
5-5: MD013 addition and 120-char limit look goodThis aligns with the README changes and is a reasonable limit.
README.md (4)
1-1: Good use of markdownlint disable/enable fence around the badge HTMLThis cleanly scopes MD013/MD033/MD041 to just the badges section.
Also applies to: 67-67
4-65: Security hardening on external links is solidAdding rel="noopener noreferrer" on all target=_blank links mitigates tabnabbing. Consistent across all anchors.
60-65: Nice update to pkg.go.dev badge/linkThis replaces deprecated godoc.org and follows current best practice.
34-35: Badge Endpoint Validated
- The CodeRabbit shields URL (
https://img.shields.io/coderabbit/prs/github/AlphaOne1/geany) returns HTTP 200 and renders correctly.- No updates to the README badge are required.
Summary by CodeRabbit
Documentation
noopener noreferrerto external links.pkg.go.dev.Chores