Skip to content

Update project metadata and UV index configuration#1047

Open
MH0386 wants to merge 9 commits into
mainfrom
uv-sources
Open

Update project metadata and UV index configuration#1047
MH0386 wants to merge 9 commits into
mainfrom
uv-sources

Conversation

@MH0386
Copy link
Copy Markdown
Contributor

@MH0386 MH0386 commented Jan 12, 2026

This pull request makes minor updates to the pyproject.toml configuration, primarily affecting Python version support and the way PyTorch CUDA dependencies are specified.

  • Python version support:

    • Removed Python 3.12 from the list of supported programming language classifiers, now only listing Python 3.13.
  • Dependency configuration:

    • Removed the [tool.uv.sources] section that explicitly set custom indexes for torch and torchaudio, simplifying the way these dependencies are sourced.

Copilot AI review requested due to automatic review settings January 12, 2026 16:40
@semanticdiff-com
Copy link
Copy Markdown

Review changes with  SemanticDiff

@gitnotebooks
Copy link
Copy Markdown

gitnotebooks Bot commented Jan 12, 2026

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 12, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated minimum Python version requirement from 3.12 to 3.13.
    • Simplified PyTorch dependency package source configuration.
    • Updated development environment settings to ignore IDE configuration files.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

Updated project configuration: bumped required Python to 3.13, removed the [tool.uv.sources] block and the explicit = true directive under [[tool.uv.index]] in pyproject.toml; added .vscode/settings.json to .gitignore.

Changes

Cohort / File(s) Summary
Project config
pyproject.toml
Updated requires-python from ">=3.12, <3.13" to ">=3.13,<3.14"; removed Programming Language :: Python :: 3.12 classifier; deleted [tool.uv.sources] block; removed explicit = true from [[tool.uv.index]] (name and url retained).
Git ignore
.gitignore
Added .vscode/settings.json to ignore list; retained existing pycrucible_payload/ entry.

Sequence Diagram(s)

(omitted — changes are configuration and doc-level, no new multi-component control flow)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Remove unused dependencies #140: Modifies pyproject.toml tool.uv.sources entries (removal of custom sources), closely related to this PR's source deletions.
  • Update pyproject.toml #311: Adds the same tool.uv.sources and [[tool.uv.index]] entries that this PR removes, indicating a direct code-level relation or reversal.

Poem

🐰 I hopped through toml with a curious twitch,

Snipped a source and trimmed a Python stitch.
Index kept its name, flags set adrift,
VSCode tucked away—what a neat little shift.
A tiny rabbit dance for a cleaner git! 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The PR title 'Update project metadata and UV index configuration' directly aligns with the main changes: updating pyproject.toml (project metadata) and removing UV index configuration.
Description check ✅ Passed The PR description is directly related to the changeset, detailing the removal of Python 3.12 classifier and [tool.uv.sources] section from pyproject.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch uv-sources

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @MH0386, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's metadata and dependency management configuration. It updates the pyproject.toml file to reflect changes in supported Python versions and simplifies how the uv package manager resolves dependencies from custom indices, leading to a cleaner and potentially more efficient build process.

Highlights

  • Python 3.12 Classifier Removal: The Programming Language :: Python :: 3.12 classifier has been removed from pyproject.toml, indicating a shift in declared Python version support.
  • UV Index Configuration Simplification: The [tool.uv.sources] section and the explicit = true flag within the [[tool.uv.index]] configuration for pytorch-cu124 have been removed, streamlining the uv dependency resolution setup.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@deepsource-io
Copy link
Copy Markdown
Contributor

deepsource-io Bot commented Jan 12, 2026

Here's the code health analysis summary for commits b84a1c5..49a6724. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Docker LogoDocker✅ SuccessView Check ↗
DeepSource Secrets LogoSecrets✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 12, 2026

🧪 CI Insights

Here's what we observed from your CI run for 49a6724.

🟢 All jobs passed!

But CI Insights is watching 👀

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's metadata in pyproject.toml by removing an explicit uv source configuration and updating Python version classifiers. The change to the uv configuration correctly simplifies how PyTorch is sourced, relying on the modern PyPI distribution. However, the update to the Python classifiers introduces an inconsistency with the project's requires-python setting, which I've provided feedback on.

Comment thread pyproject.toml
Comment on lines 11 to 15
classifiers = [
"Environment :: GPU :: NVIDIA CUDA :: 12 :: 12.4",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Topic :: Scientific/Engineering :: Artificial Intelligence",
]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There appears to be a mismatch between the requires-python setting and the classifiers. The requires-python is set to >=3.12, <3.13, which indicates the project supports Python 3.12 but not 3.13. The uv.lock file also specifies requires-python = "==3.12.*", reinforcing that Python 3.12 is the target version.

However, this change removes the Programming Language :: Python :: 3.12 classifier while keeping the incorrect Programming Language :: Python :: 3.13 classifier. To ensure the project metadata is accurate, I recommend restoring the Python 3.12 classifier and removing the one for Python 3.13.

Suggested change
classifiers = [
"Environment :: GPU :: NVIDIA CUDA :: 12 :: 12.4",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Topic :: Scientific/Engineering :: Artificial Intelligence",
]
classifiers = [
"Environment :: GPU :: NVIDIA CUDA :: 12 :: 12.4",
"Programming Language :: Python :: 3.12",
"Topic :: Scientific/Engineering :: Artificial Intelligence",
]

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modifies the project metadata and UV package manager configuration by removing the Python 3.12 classifier and simplifying the PyTorch index configuration by removing the explicit sources section and the explicit flag.

Changes:

  • Removes the Python 3.12 classifier from the project metadata while keeping Python 3.13
  • Removes the [tool.uv.sources] section that directed torch and torchaudio to use the pytorch-cu124 index
  • Removes the explicit = true flag from the UV index configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
classifiers = [
"Environment :: GPU :: NVIDIA CUDA :: 12 :: 12.4",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python version classifier is inconsistent with the project's actual Python version requirements. The project specifies requires-python = ">=3.12, <3.13" on line 6, which means it only supports Python 3.12. However, the classifier now lists Python 3.13 without listing Python 3.12. Either the Python 3.12 classifier should be kept and the 3.13 classifier removed, or the requires-python constraint should be updated to support Python 3.13.

Suggested change
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.12",

Copilot uses AI. Check for mistakes.
Comment thread pyproject.toml
explicit = true
name = "pytorch-cu124"
url = "https://download.pytorch.org/whl/cu124"

Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the [tool.uv.sources] section and the explicit = true flag may cause PyTorch to be installed from the default PyPI index instead of the CUDA-specific pytorch-cu124 index. The project has a classifier indicating it requires "NVIDIA CUDA :: 12 :: 12.4", but without the sources configuration, uv may not install the correct CUDA-enabled PyTorch builds. The lockfile currently shows torch being installed from PyPI, which may not include CUDA support. Consider whether this change is intentional, and if CUDA support is required, the sources configuration should be retained.

Suggested change
[tool.uv.sources]
torch = { index = "pytorch-cu124", explicit = true }

Copilot uses AI. Check for mistakes.
Copilot AI review requested due to automatic review settings January 12, 2026 16:50
@socket-security
Copy link
Copy Markdown

socket-security Bot commented Jan 12, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedgradio@​5.50.0 ⏵ 6.3.073 +385100100100

View full report

Copilot AI review requested due to automatic review settings January 12, 2026 17:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@mergify mergify Bot temporarily deployed to code_quality January 12, 2026 17:27 Inactive
@sonarqubecloud
Copy link
Copy Markdown

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 12, 2026

Hi @MH0386, Your PR is in conflict and cannot be merged.

@mergify mergify Bot temporarily deployed to docker_image January 12, 2026 17:51 Inactive
@mergify mergify Bot temporarily deployed to docker_image January 12, 2026 17:51 Inactive
@mergify mergify Bot temporarily deployed to docker_image January 12, 2026 17:51 Inactive
@mergify mergify Bot temporarily deployed to docker_image January 12, 2026 17:57 Inactive
@mergify mergify Bot added the conflict label Jan 12, 2026
@mergify mergify Bot added dependencies Pull requests that update a dependency file python uv labels Apr 9, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 9, 2026

👋 MH0386 your PR is conflicting and needs to be updated to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflict dependencies Pull requests that update a dependency file python uv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants