Update project metadata and UV index configuration#1047
Conversation
|
Review these changes at https://app.gitnotebooks.com/AlphaSphereDotAI/vocalizr/pull/1047 |
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughUpdated project configuration: bumped required Python to 3.13, removed the Changes
Sequence Diagram(s)(omitted — changes are configuration and doc-level, no new multi-component control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @MH0386, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project's metadata and dependency management configuration. It updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Here's the code health analysis summary for commits Analysis Summary
|
🧪 CI InsightsHere's what we observed from your CI run for 49a6724. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Code Review
This pull request updates the project's metadata in pyproject.toml by removing an explicit uv source configuration and updating Python version classifiers. The change to the uv configuration correctly simplifies how PyTorch is sourced, relying on the modern PyPI distribution. However, the update to the Python classifiers introduces an inconsistency with the project's requires-python setting, which I've provided feedback on.
| classifiers = [ | ||
| "Environment :: GPU :: NVIDIA CUDA :: 12 :: 12.4", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", | ||
| "Topic :: Scientific/Engineering :: Artificial Intelligence", | ||
| ] |
There was a problem hiding this comment.
There appears to be a mismatch between the requires-python setting and the classifiers. The requires-python is set to >=3.12, <3.13, which indicates the project supports Python 3.12 but not 3.13. The uv.lock file also specifies requires-python = "==3.12.*", reinforcing that Python 3.12 is the target version.
However, this change removes the Programming Language :: Python :: 3.12 classifier while keeping the incorrect Programming Language :: Python :: 3.13 classifier. To ensure the project metadata is accurate, I recommend restoring the Python 3.12 classifier and removing the one for Python 3.13.
| classifiers = [ | |
| "Environment :: GPU :: NVIDIA CUDA :: 12 :: 12.4", | |
| "Programming Language :: Python :: 3.12", | |
| "Programming Language :: Python :: 3.13", | |
| "Topic :: Scientific/Engineering :: Artificial Intelligence", | |
| ] | |
| classifiers = [ | |
| "Environment :: GPU :: NVIDIA CUDA :: 12 :: 12.4", | |
| "Programming Language :: Python :: 3.12", | |
| "Topic :: Scientific/Engineering :: Artificial Intelligence", | |
| ] |
There was a problem hiding this comment.
Pull request overview
This pull request modifies the project metadata and UV package manager configuration by removing the Python 3.12 classifier and simplifying the PyTorch index configuration by removing the explicit sources section and the explicit flag.
Changes:
- Removes the Python 3.12 classifier from the project metadata while keeping Python 3.13
- Removes the
[tool.uv.sources]section that directed torch and torchaudio to use the pytorch-cu124 index - Removes the
explicit = trueflag from the UV index configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| classifiers = [ | ||
| "Environment :: GPU :: NVIDIA CUDA :: 12 :: 12.4", | ||
| "Programming Language :: Python :: 3.12", | ||
| "Programming Language :: Python :: 3.13", |
There was a problem hiding this comment.
The Python version classifier is inconsistent with the project's actual Python version requirements. The project specifies requires-python = ">=3.12, <3.13" on line 6, which means it only supports Python 3.12. However, the classifier now lists Python 3.13 without listing Python 3.12. Either the Python 3.12 classifier should be kept and the 3.13 classifier removed, or the requires-python constraint should be updated to support Python 3.13.
| "Programming Language :: Python :: 3.13", | |
| "Programming Language :: Python :: 3.12", |
| explicit = true | ||
| name = "pytorch-cu124" | ||
| url = "https://download.pytorch.org/whl/cu124" | ||
|
|
There was a problem hiding this comment.
Removing the [tool.uv.sources] section and the explicit = true flag may cause PyTorch to be installed from the default PyPI index instead of the CUDA-specific pytorch-cu124 index. The project has a classifier indicating it requires "NVIDIA CUDA :: 12 :: 12.4", but without the sources configuration, uv may not install the correct CUDA-enabled PyTorch builds. The lockfile currently shows torch being installed from PyPI, which may not include CUDA support. Consider whether this change is intentional, and if CUDA support is required, the sources configuration should be retained.
| [tool.uv.sources] | |
| torch = { index = "pytorch-cu124", explicit = true } |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
|
Hi @MH0386, Your PR is in conflict and cannot be merged. |
|
👋 MH0386 your PR is conflicting and needs to be updated to be merged |



This pull request makes minor updates to the
pyproject.tomlconfiguration, primarily affecting Python version support and the way PyTorch CUDA dependencies are specified.Python version support:
Dependency configuration:
[tool.uv.sources]section that explicitly set custom indexes fortorchandtorchaudio, simplifying the way these dependencies are sourced.